Changeset 251684 in webkit for trunk/Source/JavaScriptCore/parser/SyntaxChecker.h

Timestamp:

Oct 28, 2019, 4:42:05 PM (6 years ago)

Author:

Ross Kirsling

Message:

[JSC] Lexer flags should be an OptionSet
​https://bugs.webkit.org/show_bug.cgi?id=203032

Reviewed by Yusuke Suzuki.

LexerFlags has an annoyingly misspelled value LexexFlagsDontBuildKeywords;
let's use this as an opportunity to modernize this enum.

• parser/ASTBuilder.h:
• parser/Lexer.cpp:

(JSC::Lexer<LChar>::parseIdentifier):
(JSC::Lexer<UChar>::parseIdentifier):
(JSC::Lexer<CharacterType>::parseIdentifierSlowCase):
(JSC::Lexer<T>::lexWithoutClearingLineTerminator):

• parser/Lexer.h:

(JSC::Lexer<T>::lexExpectIdentifier):
(JSC::Lexer<T>::lex):

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseProperty):
(JSC::Parser<LexerType>::parseMemberExpression):

• parser/Parser.h:

(JSC::Parser::next):
(JSC::Parser::nextWithoutClearingLineTerminator):
(JSC::Parser::nextExpectIdentifier):
(JSC::Parser::consume):

• parser/SyntaxChecker.h:

File:

• trunk/Source/JavaScriptCore/parser/SyntaxChecker.h (modified) (1 diff)

trunk/Source/JavaScriptCore/parser/SyntaxChecker.h

@@ -144 +144 @@
     static constexpr bool NeedsFreeVariableInfo = false;
     static constexpr bool CanUseFunctionCache = true;
-    static constexpr unsigned DontBuildKeywords = LexexFlagsDontBuildKeywords;
-    static constexpr unsigned DontBuildStrings = LexerFlagsDontBuildStrings;
+    static constexpr OptionSet<LexerFlags> DontBuildKeywords = LexerFlags::DontBuildKeywords;
+    static constexpr OptionSet<LexerFlags> DontBuildStrings = LexerFlags::DontBuildStrings;
 
     int createSourceElements() { return SourceElementsResult; }