Changeset 251966 in webkit for trunk/Source/JavaScriptCore/offlineasm/risc.rb

Timestamp:

Nov 2, 2019, 1:12:38 PM (6 years ago)

Author:

[email protected]

Message:

The offline assembler is wrong about which immediates are supported by and/or/xor on ARM64
​https://bugs.webkit.org/show_bug.cgi?id=203752

Reviewed by Tadeu Zagallo.

See ​https://dinfuehr.github.io/blog/encoding-of-immediate-values-on-aarch64/ for the details of which immediates are supported.
This patch is a minimal fix, ideally we should refactor all of the code dealing with immediates in risc.rb, but considering that I don't know ruby and this code is poorly/not tested, I went for the simplest possible fix.

• offlineasm/arm64.rb:
• offlineasm/mips.rb:
• offlineasm/risc.rb:

File:

• trunk/Source/JavaScriptCore/offlineasm/risc.rb (modified) (2 diffs)

trunk/Source/JavaScriptCore/offlineasm/risc.rb

@@ -363 +363 @@
 end
 
-def riscLowerMalformedImmediates(list, validImmediates)
+def riscLowerMalformedImmediates(list, validImmediates, validLogicalImmediates)
     newList = []
     list.each {
@@ -396 +396 @@
                     newList << node.riscLowerMalformedImmediatesRecurse(newList, validImmediates)
                 end
+            when "ori", "orh", "orp", "oris", "xori", "xorp", "andi", "andp"
+                newList << node.riscLowerMalformedImmediatesRecurse(newList, validLogicalImmediates)
             else
                 newList << node.riscLowerMalformedImmediatesRecurse(newList, validImmediates)