Changeset 251978 in webkit for trunk/Source/JavaScriptCore/ChangeLog

Timestamp:

Nov 3, 2019, 8:11:43 PM (6 years ago)

Author:

Tadeu Zagallo

Message:

LLIntGenerator should not allocate temporaries in between variables
​https://bugs.webkit.org/show_bug.cgi?id=203787

Reviewed by Yusuke Suzuki.

JSTests:

• wasm/stress/local-ref.js: Added.

Source/JavaScriptCore:

The BytecodeGenerator requires that all variables must be allocated contiguously, before any
temporaries are allocated. Currently, we might end up allocating a temporary to materialize
the null constant to initialize locals of type Anyref/Funcref. Fix it by keeping track of the
locals that need to be initialized and adding a new callback to notify when we have finished
parsing locals. Only then we perform the delayed initialization of local refs.

• wasm/WasmAirIRGenerator.cpp:

(JSC::Wasm::AirIRGenerator::didFinishParsingLocals):

• wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::didFinishParsingLocals):

• wasm/WasmFunctionParser.h:

(JSC::Wasm::FunctionParser<Context>::parse):

• wasm/WasmLLIntGenerator.cpp:

(JSC::Wasm::LLIntGenerator::addLocal):
(JSC::Wasm::LLIntGenerator::didFinishParsingLocals):

• wasm/WasmValidate.cpp:

(JSC::Wasm::Validate::didFinishParsingLocals):

File:

• trunk/Source/JavaScriptCore/ChangeLog (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-11-03  Tadeu Zagallo  <[email protected]>
+
+        LLIntGenerator should not allocate temporaries in between variables
+        https://bugs.webkit.org/show_bug.cgi?id=203787
+
+        Reviewed by Yusuke Suzuki.
+
+        The BytecodeGenerator requires that all variables must be allocated contiguously, before any
+        temporaries are allocated. Currently, we might end up allocating a temporary to materialize
+        the null constant to initialize locals of type Anyref/Funcref. Fix it by keeping track of the
+        locals that need to be initialized and adding a new callback to notify when we have finished
+        parsing locals. Only then we perform the delayed initialization of local refs.
+
+        * wasm/WasmAirIRGenerator.cpp:
+        (JSC::Wasm::AirIRGenerator::didFinishParsingLocals):
+        * wasm/WasmB3IRGenerator.cpp:
+        (JSC::Wasm::B3IRGenerator::didFinishParsingLocals):
+        * wasm/WasmFunctionParser.h:
+        (JSC::Wasm::FunctionParser<Context>::parse):
+        * wasm/WasmLLIntGenerator.cpp:
+        (JSC::Wasm::LLIntGenerator::addLocal):
+        (JSC::Wasm::LLIntGenerator::didFinishParsingLocals):
+        * wasm/WasmValidate.cpp:
+        (JSC::Wasm::Validate::didFinishParsingLocals):
+
 2019-11-02  Alexey Proskuryakov  <[email protected]>