Changeset 252753 in webkit for trunk/Source/JavaScriptCore/builtins

Timestamp:

Nov 21, 2019, 3:18:48 PM (6 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r252683 and r252721.
​https://bugs.webkit.org/show_bug.cgi?id=204475

13% regression in JetStream2/prepack-wtb (Requested by
yusukesuzuki on #webkit).

Reverted changesets:

"Implement String.prototype.replaceAll"
​https://bugs.webkit.org/show_bug.cgi?id=202471
​https://trac.webkit.org/changeset/252683

"Unreviewed, address Darin's feedback on r252683."
​https://trac.webkit.org/changeset/252721

Location:

trunk/Source/JavaScriptCore/builtins

Files:

• BuiltinNames.h (modified) (1 diff)
• StringPrototype.js (modified) (1 diff)

trunk/Source/JavaScriptCore/builtins/BuiltinNames.h

@@ -133 +133 @@
     macro(replaceUsingRegExp) \
     macro(replaceUsingStringSearch) \
-    macro(replaceAllUsingStringSearch) \
     macro(makeTypeError) \
     macro(mapBucket) \

trunk/Source/JavaScriptCore/builtins/StringPrototype.js

@@ -260 +260 @@
 }
 
-function replaceAll(search, replace)
-{
-    "use strict";
-
-    if (@isUndefinedOrNull(this))
-        @throwTypeError("String.prototype.replaceAll requires |this| not to be null nor undefined");
-
-    if (search != null) {
-        if (@isRegExp(search) && !@stringIncludesInternal.@call(@toString(search.flags), "g"))
-            @throwTypeError("String.prototype.replaceAll argument must not be a non-global regular expression");
-
-        var replacer = search.@replaceSymbol;
-        if (replacer !== @undefined) {
-            if (!@hasObservableSideEffectsForStringReplace(search, replacer))
-                return @toString(this).@replaceUsingRegExp(search, replace);
-            return replacer.@call(search, this, replace);
-        }
-    }
-
-    var thisString = @toString(this);
-    var searchString = @toString(search);
-    return thisString.@replaceAllUsingStringSearch(searchString, replace);
-}
-
 function search(regexp)
 {