Changeset 252754 in webkit for trunk/Source/JavaScriptCore/builtins

Timestamp:

Nov 21, 2019, 3:35:21 PM (5 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling in again, regression is not caused by it
​https://bugs.webkit.org/show_bug.cgi?id=202471

JSTests:

• stress/string-replaceall.js: Added.

(shouldBe):
(shouldThrowTypeError):
(shouldBe.string_appeared_here.replaceAll.Symbol.match):

Source/JavaScriptCore:

• builtins/BuiltinNames.h:
• builtins/StringPrototype.js:

(replaceAll):

• runtime/StringPrototype.cpp:

(JSC::StringPrototype::finishCreation):
(JSC::jsSpliceSubstringsWithSeparators):
(JSC::replaceUsingStringSearch):
(JSC::replace):
(JSC::stringProtoFuncReplaceUsingStringSearch):
(JSC::stringProtoFuncReplaceAllUsingStringSearch):

Source/WTF:

• wtf/text/StringCommon.h:

(WTF::findCommon):

LayoutTests:

• js/Object-getOwnPropertyNames-expected.txt:
• js/script-tests/Object-getOwnPropertyNames.js:

Location:

trunk/Source/JavaScriptCore/builtins

Files:

• BuiltinNames.h (modified) (1 diff)
• StringPrototype.js (modified) (1 diff)

trunk/Source/JavaScriptCore/builtins/BuiltinNames.h

@@ -133 +133 @@
     macro(replaceUsingRegExp) \
     macro(replaceUsingStringSearch) \
+    macro(replaceAllUsingStringSearch) \
     macro(makeTypeError) \
     macro(mapBucket) \

trunk/Source/JavaScriptCore/builtins/StringPrototype.js

@@ -260 +260 @@
 }
 
+function replaceAll(search, replace)
+{
+    "use strict";
+
+    if (@isUndefinedOrNull(this))
+        @throwTypeError("String.prototype.replaceAll requires |this| not to be null nor undefined");
+
+    if (search != null) {
+        if (@isRegExp(search) && !@stringIncludesInternal.@call(@toString(search.flags), "g"))
+            @throwTypeError("String.prototype.replaceAll argument must not be a non-global regular expression");
+
+        var replacer = search.@replaceSymbol;
+        if (replacer !== @undefined) {
+            if (!@hasObservableSideEffectsForStringReplace(search, replacer))
+                return @toString(this).@replaceUsingRegExp(search, replace);
+            return replacer.@call(search, this, replace);
+        }
+    }
+
+    var thisString = @toString(this);
+    var searchString = @toString(search);
+    return thisString.@replaceAllUsingStringSearch(searchString, replace);
+}
+
 function search(regexp)
 {