Changeset 255994 in webkit for trunk/Source/JavaScriptCore/bytecode/CodeBlock.cpp

Timestamp:

Feb 6, 2020, 5:32:50 PM (6 years ago)

Author:

Ryan Haddad

Message:

Unreviewed, rolling out r255987.
​https://bugs.webkit.org/show_bug.cgi?id=207369

JSTests failures (Requested by yusukesuzuki on #webkit).

Reverted changeset:

"[JSC] CodeBlock::shrinkToFit should shrink
m_constantRegisters and m_constantsSourceCodeRepresentation in
64bit architectures"
​https://bugs.webkit.org/show_bug.cgi?id=207356
​https://trac.webkit.org/changeset/255987

Patch by Commit Queue <​[email protected]> on 2020-02-06

File:

• trunk/Source/JavaScriptCore/bytecode/CodeBlock.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/bytecode/CodeBlock.cpp

@@ -1954 +1954 @@
 }
 
-void CodeBlock::shrinkToFit(const ConcurrentJSLocker&, ShrinkMode shrinkMode)
+void CodeBlock::shrinkToFit(ShrinkMode shrinkMode)
 {
     ConcurrentJSLocker locker(m_lock);
 
-#if USE(JSVALUE32_64)
-    // Only 32bit Baseline JIT is touching m_constantRegisters address directly.
-    if (shrinkMode == ShrinkMode::EarlyShrink)
+    if (shrinkMode == EarlyShrink) {
         m_constantRegisters.shrinkToFit();
-#else
-    m_constantRegisters.shrinkToFit();
-#endif
-    m_constantsSourceCodeRepresentation.shrinkToFit();
-
-    if (shrinkMode == ShrinkMode::EarlyShrink) {
+        m_constantsSourceCodeRepresentation.shrinkToFit();
+        
         if (m_rareData) {
             m_rareData->m_switchJumpTables.shrinkToFit();