Changeset 255994 in webkit for trunk/Source/JavaScriptCore/dfg/DFGJITFinalizer.cpp

Timestamp:

Feb 6, 2020, 5:32:50 PM (5 years ago)

Author:

Ryan Haddad

Message:

Unreviewed, rolling out r255987.
​https://bugs.webkit.org/show_bug.cgi?id=207369

JSTests failures (Requested by yusukesuzuki on #webkit).

Reverted changeset:

"[JSC] CodeBlock::shrinkToFit should shrink
m_constantRegisters and m_constantsSourceCodeRepresentation in
64bit architectures"
​https://bugs.webkit.org/show_bug.cgi?id=207356
​https://trac.webkit.org/changeset/255987

Patch by Commit Queue <​[email protected]> on 2020-02-06

File:

• trunk/Source/JavaScriptCore/dfg/DFGJITFinalizer.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/dfg/DFGJITFinalizer.cpp

@@ -84 +84 @@
     CodeBlock* codeBlock = m_plan.codeBlock();
 
+    // Some JIT finalizers may have added more constants. Shrink-to-fit those things now.
+    {
+        ConcurrentJSLocker locker(codeBlock->m_lock);
+        codeBlock->constants().shrinkToFit();
+        codeBlock->constantsSourceCodeRepresentation().shrinkToFit();
+    }
+
 #if ENABLE(FTL_JIT)
     m_jitCode->optimizeAfterWarmUp(codeBlock);