Changeset 255994 in webkit for trunk/Source/JavaScriptCore/jit/JIT.cpp

Timestamp:

Feb 6, 2020, 5:32:50 PM (5 years ago)

Author:

Ryan Haddad

Message:

Unreviewed, rolling out r255987.
​https://bugs.webkit.org/show_bug.cgi?id=207369

JSTests failures (Requested by yusukesuzuki on #webkit).

Reverted changeset:

"[JSC] CodeBlock::shrinkToFit should shrink
m_constantRegisters and m_constantsSourceCodeRepresentation in
64bit architectures"
​https://bugs.webkit.org/show_bug.cgi?id=207356
​https://trac.webkit.org/changeset/255987

Patch by Commit Queue <​[email protected]> on 2020-02-06

File:

• trunk/Source/JavaScriptCore/jit/JIT.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/jit/JIT.cpp

@@ -944 +944 @@
         static_cast<double>(m_codeBlock->instructionsSize()));
 
-    {
-        ConcurrentJSLocker locker(m_codeBlock->m_lock);
-        m_codeBlock->shrinkToFit(locker, CodeBlock::ShrinkMode::LateShrink);
-    }
+    m_codeBlock->shrinkToFit(CodeBlock::LateShrink);
     m_codeBlock->setJITCode(
         adoptRef(*new DirectJITCode(result, withArityCheck, JITType::BaselineJIT)));