Changeset 256003 in webkit for trunk/Source/JavaScriptCore/b3/B3PatchpointSpecial.cpp

Timestamp:

Feb 6, 2020, 7:12:32 PM (5 years ago)

Author:

[email protected]

Message:

Most of B3 and Air does not need to include CCallHelpers.h
​https://bugs.webkit.org/show_bug.cgi?id=206975

Reviewed by Mark Lam.

They only do to use CCallHelpers::Jump or CCallHelpers::Label.
But CCallHelpers inherit those from MacroAssembler. And MacroAssembler.h is dramatically cheaper to include (since CCallHelpers includes AssemblyHelpers which includes CodeBlock.h which includes roughly the entire runtime).

• b3/B3CheckSpecial.cpp:
• b3/B3CheckSpecial.h:
• b3/B3LowerMacros.cpp:
• b3/B3PatchpointSpecial.cpp:

(JSC::B3::PatchpointSpecial::generate):

• b3/B3PatchpointSpecial.h:
• b3/B3StackmapGenerationParams.cpp:

(JSC::B3::StackmapGenerationParams::successorLabels const):

• b3/B3StackmapGenerationParams.h:
• b3/air/AirAllocateRegistersAndStackAndGenerateCode.h:
• b3/air/AirCCallSpecial.cpp:
• b3/air/AirCCallSpecial.h:
• b3/air/AirCode.cpp:
• b3/air/AirCode.h:

(JSC::B3::Air::Code::entrypointLabel const):

• b3/air/AirCustom.cpp:

(JSC::B3::Air::CCallCustom::generate):
(JSC::B3::Air::ShuffleCustom::generate):
(JSC::B3::Air::WasmBoundsCheckCustom::generate):

• b3/air/AirCustom.h:

(JSC::B3::Air::PatchCustom::generate):
(JSC::B3::Air::EntrySwitchCustom::generate):

• b3/air/AirDisassembler.cpp:

(JSC::B3::Air::Disassembler::addInst):

• b3/air/AirDisassembler.h:
• b3/air/AirGenerationContext.h:
• b3/air/AirInst.h:
• b3/air/AirPrintSpecial.cpp:

(JSC::B3::Air::PrintSpecial::generate):

• b3/air/AirPrintSpecial.h:
• b3/air/AirSpecial.h:
• b3/air/AirValidate.cpp:
• b3/air/opcode_generator.rb:

File:

• trunk/Source/JavaScriptCore/b3/B3PatchpointSpecial.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/b3/B3PatchpointSpecial.cpp

@@ -147 +147 @@
 }
 
-CCallHelpers::Jump PatchpointSpecial::generate(Inst& inst, CCallHelpers& jit, Air::GenerationContext& context)
+MacroAssembler::Jump PatchpointSpecial::generate(Inst& inst, CCallHelpers& jit, Air::GenerationContext& context)
 {
     const Procedure& procedure = code().proc();
@@ -171 +171 @@
     value->m_generator->run(jit, params);
 
-    return CCallHelpers::Jump();
+    return MacroAssembler::Jump();
 }