Ignore:
Timestamp:
Apr 20, 2020, 11:11:07 PM (5 years ago)
Author:
Ross Kirsling
Message:

Classes marked final should not use protected access specifier
​https://bugs.webkit.org/show_bug.cgi?id=210775

Reviewed by Daniel Bates.

Source/JavaScriptCore:

  • API/JSAPIValueWrapper.h:
  • API/JSCallbackConstructor.h:
  • API/JSCallbackObject.h:
  • b3/B3ExtractValue.h:
  • bytecode/UnlinkedFunctionExecutable.h:
  • inspector/JSGlobalObjectConsoleClient.h:
  • inspector/JSInjectedScriptHost.h:
  • inspector/JSJavaScriptCallFrame.h:
  • jsc.cpp:
  • runtime/AggregateError.h:
  • runtime/AggregateErrorPrototype.h:
  • runtime/ArrayConstructor.h:
  • runtime/ArrayPrototype.h:
  • runtime/AsyncFunctionPrototype.h:
  • runtime/AsyncGeneratorFunctionPrototype.h:
  • runtime/AtomicsObject.h:
  • runtime/BigIntConstructor.h:
  • runtime/BigIntObject.h:
  • runtime/BigIntPrototype.h:
  • runtime/BooleanConstructor.h:
  • runtime/BooleanPrototype.h:
  • runtime/ConsoleObject.h:
  • runtime/DateConstructor.h:
  • runtime/DatePrototype.h:
  • runtime/ErrorConstructor.h:
  • runtime/ErrorPrototype.h:
  • runtime/FileBasedFuzzerAgent.h:
  • runtime/FunctionPrototype.h:
  • runtime/FunctionRareData.h:
  • runtime/GeneratorFunctionPrototype.h:
  • runtime/GenericTypedArrayView.h:
  • runtime/InspectorInstrumentationObject.h:
  • runtime/IntlCollator.h:
  • runtime/IntlCollatorConstructor.h:
  • runtime/IntlCollatorPrototype.h:
  • runtime/IntlDateTimeFormat.h:
  • runtime/IntlDateTimeFormatConstructor.h:
  • runtime/IntlDateTimeFormatPrototype.h:
  • runtime/IntlNumberFormat.h:
  • runtime/IntlNumberFormatConstructor.h:
  • runtime/IntlNumberFormatPrototype.h:
  • runtime/IntlPluralRules.h:
  • runtime/IntlPluralRulesConstructor.h:
  • runtime/IntlPluralRulesPrototype.h:
  • runtime/IntlRelativeTimeFormatConstructor.h:
  • runtime/IntlRelativeTimeFormatPrototype.h:
  • runtime/JSArrayBuffer.h:
  • runtime/JSArrayBufferConstructor.h:
  • runtime/JSArrayBufferPrototype.h:
  • runtime/JSAsyncGenerator.h:
  • runtime/JSBoundFunction.h:
  • runtime/JSCustomGetterSetterFunction.h:
  • runtime/JSDataView.h:
  • runtime/JSDataViewPrototype.h:
  • runtime/JSGenerator.h:
  • runtime/JSGenericTypedArrayView.h:
  • runtime/JSGenericTypedArrayViewConstructor.h:
  • runtime/JSGenericTypedArrayViewPrototype.h:
  • runtime/JSGlobalLexicalEnvironment.h:
  • runtime/JSModuleLoader.h:
  • runtime/JSModuleNamespaceObject.h:
  • runtime/JSNativeStdFunction.h:
  • runtime/JSONObject.h:
  • runtime/JSObject.h:
  • runtime/JSTemplateObjectDescriptor.h:
  • runtime/JSTypedArrayViewConstructor.h:
  • runtime/JSTypedArrayViewPrototype.h:
  • runtime/MathObject.h:
  • runtime/NativeExecutable.h:
  • runtime/NumberConstructor.h:
  • runtime/NumberPrototype.h:
  • runtime/ObjectConstructor.h:
  • runtime/ObjectPrototype.h:
  • runtime/PredictionFileCreatingFuzzerAgent.h:
  • runtime/ReflectObject.h:
  • runtime/RegExp.h:
  • runtime/RegExpConstructor.h:
  • runtime/RegExpObject.h:
  • runtime/RegExpPrototype.h:
  • runtime/StringPrototype.h:
  • runtime/Structure.h:
  • runtime/Symbol.h:
  • runtime/SymbolConstructor.h:
  • runtime/SymbolObject.h:
  • runtime/SymbolPrototype.h:
  • runtime/VMTraps.cpp:
  • testRegExp.cpp:
  • wasm/WasmBBQPlan.h:
  • wasm/WasmLLIntPlan.h:
  • wasm/WasmWorklist.cpp:
  • wasm/js/JSWebAssembly.h:
  • wasm/js/JSWebAssemblyCompileError.h:
  • wasm/js/JSWebAssemblyInstance.h:
  • wasm/js/JSWebAssemblyLinkError.h:
  • wasm/js/JSWebAssemblyRuntimeError.h:
  • wasm/js/WebAssemblyCompileErrorConstructor.h:
  • wasm/js/WebAssemblyCompileErrorPrototype.h:
  • wasm/js/WebAssemblyGlobalConstructor.h:
  • wasm/js/WebAssemblyGlobalPrototype.h:
  • wasm/js/WebAssemblyInstanceConstructor.h:
  • wasm/js/WebAssemblyInstancePrototype.h:
  • wasm/js/WebAssemblyLinkErrorConstructor.h:
  • wasm/js/WebAssemblyLinkErrorPrototype.h:
  • wasm/js/WebAssemblyMemoryConstructor.h:
  • wasm/js/WebAssemblyMemoryPrototype.h:
  • wasm/js/WebAssemblyModuleConstructor.h:
  • wasm/js/WebAssemblyModulePrototype.h:
  • wasm/js/WebAssemblyRuntimeErrorConstructor.h:
  • wasm/js/WebAssemblyRuntimeErrorPrototype.h:
  • wasm/js/WebAssemblyTableConstructor.h:
  • wasm/js/WebAssemblyTablePrototype.h:
  • wasm/js/WebAssemblyWrapperFunction.h:

Source/WebCore:

  • Modules/applepay/ApplePayPaymentMethodSelectedEvent.h:
  • Modules/applepay/ApplePayValidateMerchantEvent.h:
  • Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.h:
  • Modules/webaudio/BiquadDSPKernel.h:
  • Modules/webaudio/WaveShaperDSPKernel.h:
  • Modules/websockets/WebSocketChannel.h:
  • Modules/websockets/WorkerThreadableWebSocketChannel.h:
  • Modules/webxr/WebXRSession.h:
  • Modules/webxr/WebXRSystem.h:
  • accessibility/AccessibilityARIAGridCell.h:
  • accessibility/AccessibleSetValueEvent.h:
  • animation/CSSAnimation.h:
  • bindings/js/ReadableStream.h:
  • bridge/objc/objc_runtime.h:
  • bridge/runtime_array.h:
  • css/CSSImageSetValue.h:
  • html/HTMLKeygenElement.cpp:
  • html/canvas/WebGLBuffer.h:
  • html/canvas/WebGLFramebuffer.h:
  • html/canvas/WebGLProgram.h:
  • html/canvas/WebGLQuery.h:
  • html/canvas/WebGLRenderbuffer.h:
  • html/canvas/WebGLSampler.h:
  • html/canvas/WebGLSync.h:
  • html/canvas/WebGLTransformFeedback.h:
  • html/canvas/WebGLUniformLocation.h:
  • html/shadow/TextControlInnerElements.h:
  • inspector/InspectorStyleSheet.h:
  • inspector/WebInjectedScriptManager.h:
  • loader/cache/CachedCSSStyleSheet.h:
  • page/Frame.h:
  • page/FrameView.h:
  • page/PageConsoleClient.h:
  • page/animation/KeyframeAnimation.h:
  • page/scrolling/nicosia/ScrollingTreeOverflowScrollProxyNode.h:
  • platform/audio/AudioBus.h:
  • platform/cocoa/PlaybackSessionModelMediaElement.h:
  • platform/graphics/BitmapImage.h:
  • platform/graphics/CrossfadeGeneratedImage.h:
  • platform/graphics/NamedImageGeneratedImage.h:
  • platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
  • platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.h:
  • platform/graphics/ca/win/PlatformCAAnimationWin.h:
  • platform/graphics/cg/ImageDecoderCG.h:
  • platform/graphics/iso/ISOOriginalFormatBox.h:
  • platform/graphics/iso/ISOProtectionSchemeInfoBox.h:
  • platform/graphics/iso/ISOSchemeInformationBox.h:
  • platform/graphics/iso/ISOSchemeTypeBox.h:
  • platform/graphics/iso/ISOTrackEncryptionBox.h:
  • platform/graphics/iso/ISOVTTCue.cpp:
  • platform/graphics/iso/ISOVTTCue.h:
  • platform/graphics/win/ImageDecoderDirect2D.h:
  • platform/mediastream/mac/AVCaptureDeviceManager.h:
  • platform/mock/mediasource/MockBox.h:
  • platform/mock/mediasource/MockSourceBufferPrivate.cpp:
  • rendering/RenderFullScreen.h:
  • rendering/RenderGrid.h:
  • rendering/RenderMultiColumnSet.h:
  • rendering/RenderRuby.h:
  • rendering/RenderScrollbarPart.h:
  • rendering/RenderScrollbarTheme.h:
  • rendering/RenderTableCell.h:
  • rendering/RenderTableSection.h:
  • rendering/RenderThemeIOS.h:
  • rendering/RenderView.h:
  • rendering/svg/RenderSVGResourceClipper.h:
  • svg/SVGTextPathElement.h:
  • workers/WorkerConsoleClient.h:
  • worklets/Worklet.h:

Source/WebKit:

  • Shared/API/APIDictionary.h:
  • WebProcess/GPU/media/TextTrackPrivateRemote.h:
  • WebProcess/Plugins/Netscape/JSNPMethod.h:
  • WebProcess/Plugins/Netscape/JSNPObject.h:

Source/WebKitLegacy:

  • WebCoreSupport/WebResourceLoadScheduler.h:

Source/WebKitLegacy/win:

  • DefaultDownloadDelegate.h:
  • DefaultPolicyDelegate.h:
  • MemoryStream.h:
  • WebApplicationCache.h:
  • WebArchive.h:
  • WebBackForwardList.h:
  • WebCache.h:
  • WebCoreStatistics.h:
  • WebDataSource.h:
  • WebElementPropertyBag.h:
  • WebError.h:
  • WebFrame.h:
  • WebFramePolicyListener.h:
  • WebHTMLRepresentation.h:
  • WebHistoryItem.h:
  • WebJavaScriptCollector.h:
  • WebKitClassFactory.h:
  • WebKitStatistics.h:
  • WebMutableURLRequest.h:
  • WebNotification.h:
  • WebNotificationCenter.h:
  • WebPreferences.h:
  • WebResource.h:
  • WebURLAuthenticationChallenge.h:
  • WebURLCredential.h:
  • WebURLProtectionSpace.h:
  • WebURLResponse.h:

Tools:

  • DumpRenderTree/win/DefaultPolicyDelegate.h:
  • DumpRenderTree/win/UIDelegate.h:
File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/testRegExp.cpp

    r259747 r260415  
    104104
    105105class GlobalObject final : public JSGlobalObject {
    106 private:
    107     GlobalObject(VM&, Structure*, const Vector<String>& arguments);
    108 
    109106public:
    110107    using Base = JSGlobalObject;
    … …  
    125122    }
    126123
    127 protected:
     124private:
     125    GlobalObject(VM&, Structure*, const Vector<String>& arguments);
     126
    128127    void finishCreation(VM& vm, const Vector<String>& arguments)
    129128    {
Note: See TracChangeset for help on using the changeset viewer.