Changeset 262389 in webkit for trunk/Source/JavaScriptCore/offlineasm

Timestamp:

Jun 1, 2020, 12:35:53 PM (5 years ago)

Author:

[email protected]

Message:

x86.rb's LabelReference.x86LoadOperand()'s address operand should be a pointer type.
​https://bugs.webkit.org/show_bug.cgi?id=212603

Reviewed by Saam Barati.

The current implementation mistakenly sets the address type to that of the value
being loaded. I encountered this issue when I was trying to do a loadb from a
global address. Because of this bug, the emitted code was trying do a load using
%al (8 byte register) as the pointer to load from. With this fix, it now loads
from %rax.

• offlineasm/x86.rb:

File:

• trunk/Source/JavaScriptCore/offlineasm/x86.rb (modified) (2 diffs)

trunk/Source/JavaScriptCore/offlineasm/x86.rb

@@ -1 @@
-# Copyright (C) 2012-2018 Apple Inc. All rights reserved.
+# Copyright (C) 2012-2020 Apple Inc. All rights reserved.
 # Copyright (C) 2013 Digia Plc. and/or its subsidiary(-ies)
 #
@@ -448 +448 @@
             $asm.puts "lea #{dst.x86Operand(:ptr)}, #{asmLabel}"
         end
-        "#{offset}(#{dst.x86Operand(kind)})"
+        "#{offset}(#{dst.x86Operand(:ptr)})"
     end
 end