Changeset 262694 in webkit for trunk/Source/JavaScriptCore/offlineasm

Timestamp:

Jun 7, 2020, 12:35:37 AM (5 years ago)

Author:

[email protected]

Message:

[JSC] Checksum for generated files should be emitted at the end of the files
​https://bugs.webkit.org/show_bug.cgi?id=212875

Reviewed by Mark Lam.

If the offlineasm file generation is interrupted in the middle of the generation, it already emitted checksum.
So next file generation can accept this broken file as a result of offlineasm and skip file generation.
We should emit checksum at the end of files. For now, this patch takes a quick way: just iterating lines, getting
a last line and use it for checksum comparison.

• generator/GeneratedFile.rb:
• offlineasm/asm.rb:

File:

• trunk/Source/JavaScriptCore/offlineasm/asm.rb (modified) (3 diffs)

trunk/Source/JavaScriptCore/offlineasm/asm.rb

@@ -364 +364 @@
 
 if FileTest.exist? outputFlnm
+    lastLine = nil
     File.open(outputFlnm, "r") {
-        | inp |
-        firstLine = inp.gets
-        if firstLine and firstLine.chomp == inputHash
-            $stderr.puts "offlineasm: Nothing changed."
-            exit 0
-        end
+        | file |
+        file.each_line {
+            | line |
+            line = line.chomp
+            unless line.empty?
+                lastLine = line
+            end
+        }
     }
+    if lastLine and lastLine == inputHash
+        $stderr.puts "Offlineasm: Nothing changed."
+        exit 0
+    end
 end
 
@@ -377 +384 @@
     | outp |
     $output = outp
-    $output.puts inputHash
 
     $asm = Assembler.new($output)
@@ -409 +415 @@
         }
     }
+
+    $output.fsync
+    $output.puts inputHash
 }