Ignore:
Timestamp:
Jun 12, 2020, 9:14:44 AM (5 years ago)
Author:
[email protected]
Message:

LayoutTests/imported/w3c:
Change FileReader.error to DOMException from obsoleted FileError
https://bugs.webkit.org/show_bug.cgi?id=213117

Patch by Tetsuharu Ohzeki <Tetsuharu Ohzeki> on 2020-06-12
Reviewed by Chris Dumez.

  • web-platform-tests/FileAPI/historical.https-expected.txt: FileError should not be exposed.

Source/WebCore:
FileReader.error should be DOMException now
https://bugs.webkit.org/show_bug.cgi?id=213117

Patch by Tetsuharu Ohzeki <Tetsuharu Ohzeki> on 2020-06-12
Reviewed by Chris Dumez.

By the [lastest spec](https://w3c.github.io/FileAPI/),
FileReader.error should return DOMException
and this remove obsoleted FileError from exposed interfaces.

Internally, our codebase still depends on fileapi/FileError.h
in everywhere. I'll plan to create a patch to refactor them.

  • CMakeLists.txt:
  • DerivedSources-input.xcfilelist:
  • DerivedSources-output.xcfilelist:
  • DerivedSources.make:
  • Sources.txt:
  • WebCore.order:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/FileError.idl: Removed.
  • fileapi/FileReader.cpp:

(WebCore::FileReader::abort):
(WebCore::FileReader::didFail):

  • fileapi/FileReader.h:
  • fileapi/FileReader.idl:
  • fileapi/FileReaderSync.cpp:

(WebCore::FileReaderSync::errorCodeToException):

  • fileapi/FileReaderSync.h:

LayoutTests:
Change FileReader.error to DOMException from obsoleted FileError
https://bugs.webkit.org/show_bug.cgi?id=213117

Patch by Tetsuharu Ohzeki <Tetsuharu Ohzeki> on 2020-06-12
Reviewed by Chris Dumez.

By the [lastest spec](https://w3c.github.io/FileAPI/),
FileReader.error should return DOMException
and this change remove FileError from exposed interfaces.

  • fast/files/file-reader-abort-expected.txt:
  • fast/files/file-reader-abort-using-open-panel-expected.txt:
  • fast/files/read-blob-async-expected.txt:
  • fast/files/read-file-async-expected.txt:
  • fast/files/workers/worker-read-blob-async-expected.txt:
  • fast/files/workers/worker-read-file-async-expected.txt: Update to DOMException error code from FileError error code.
  • platform/mac-wk1/imported/w3c/web-platform-tests/FileAPI/historical.https-expected.txt: FileError should not be exposed.
File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/fileapi/FileReaderSync.cpp

    r262430 r262953  
    3535#include "Blob.h"
    3636#include "BlobURL.h"
     37#include "FileError.h"
    3738#include "FileReaderLoader.h"
    3839#include <JavaScriptCore/ArrayBuffer.h>
     
    7374}
    7475
    75 static ExceptionOr<void> errorCodeToException(FileError::ErrorCode errorCode)
     76ExceptionOr<void> FileReaderSync::errorCodeToException(FileError::ErrorCode errorCode)
    7677{
    7778    switch (errorCode) {
Note: See TracChangeset for help on using the changeset viewer.