Ignore:
Timestamp:
Jul 16, 2020, 5:33:37 PM (5 years ago)
Author:
Fujii Hironori
Message:

[WTF] Remove the unnecessary inner class DefaultHash<T>::Hash
https://bugs.webkit.org/show_bug.cgi?id=214389

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • assembler/MacroAssemblerCodeRef.h:
  • b3/B3CheckSpecial.h:
  • b3/B3Kind.h:
  • b3/B3ValueKey.h:
  • b3/air/AirAllocateRegistersByGraphColoring.cpp:
  • b3/air/AirArg.h:
  • b3/air/AirTmp.h:
  • bytecode/BytecodeIndex.h:
  • bytecode/CallVariant.h:
  • bytecode/CodeOrigin.h:
  • bytecode/DFGExitProfile.h:
  • bytecode/LazyOperandValueProfile.h:
  • bytecode/ObjectPropertyCondition.h:
  • bytecode/PropertyCondition.h:
  • dfg/DFGAbstractHeap.h:
  • dfg/DFGArgumentsEliminationPhase.cpp:
  • dfg/DFGByteCodeParser.cpp:
  • dfg/DFGCSEPhase.cpp:
  • dfg/DFGCompilationKey.h:
  • dfg/DFGDesiredGlobalProperty.h:
  • dfg/DFGHeapLocation.h:
  • dfg/DFGLivenessAnalysisPhase.cpp:
  • dfg/DFGMinifiedID.h:
  • dfg/DFGNodeFlowProjection.h:
  • dfg/DFGPromotedHeapLocation.h:
  • dfg/DFGPropertyTypeKey.h:
  • dfg/DFGPureValue.h:
  • ftl/FTLLocation.h:
  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayWithSpread):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargsSpread):
(JSC::FTL::DFG::LowerDFGToB3::compileMaterializeNewObject):

  • ftl/FTLSlowPathCallKey.h:
  • heap/MarkedBlock.h:
  • heap/VisitRaceKey.h:
  • inspector/scripts/codegen/generate_cpp_protocol_types_header.py:
  • inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
  • inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
  • inspector/scripts/tests/expected/enum-values.json-result:
  • inspector/scripts/tests/expected/type-declaration-array-type.json-result:
  • inspector/scripts/tests/expected/type-declaration-enum-type.json-result:
  • inspector/scripts/tests/expected/type-declaration-object-type.json-result:
  • inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:
  • jit/ICStats.h:
  • jit/JITThunks.h:
  • jit/Reg.h:
  • jit/RegisterSet.h:
  • parser/VariableEnvironment.h:
  • profiler/ProfilerOrigin.h:
  • profiler/ProfilerOriginStack.h:
  • profiler/ProfilerUID.h:
  • runtime/CachedTypes.cpp:
  • runtime/ControlFlowProfiler.h:
  • runtime/NativeFunction.h:
  • runtime/PrototypeKey.h:
  • runtime/RegExpKey.h:
  • runtime/TemplateObjectDescriptor.h:
  • runtime/TypeProfiler.h:
  • runtime/VarOffset.h:
  • runtime/WeakGCMap.h:
  • wasm/WasmBBQPlan.h:
  • wasm/WasmCodeBlock.h:
  • wasm/WasmEntryPlan.h:
  • wasm/WasmLLIntPlan.h:
  • wasm/WasmSignature.h:

Source/WebCore:

  • Modules/indexeddb/IDBDatabaseIdentifier.h:
  • Modules/indexeddb/shared/IDBResourceIdentifier.h:
  • Modules/webgpu/WHLSL/AST/WHLSLUnnamedTypeHash.h:
  • Modules/webgpu/WHLSL/WHLSLSemanticMatcher.cpp:

(WebCore::WHLSL::matchResources):
(WebCore::WHLSL::matchVertexAttributes):
(WebCore::WHLSL::matchColorAttachments):

  • accessibility/AccessibilityObject.cpp:
  • accessibility/AccessibilityObject.h:
  • contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::serializeActions):

  • contentextensions/ContentExtensionRule.h:

(WebCore::ContentExtensions::TriggerHash::hash):

  • contentextensions/ContentExtensionStyleSheet.h:
  • contentextensions/DFA.cpp:

(WebCore::ContentExtensions::printTransitions):

  • contentextensions/DFABytecodeInterpreter.h:
  • contentextensions/DFACombiner.cpp:

(WebCore::ContentExtensions::DFAMerger::getOrCreateCombinedNode):

  • contentextensions/DFANode.cpp:

(WebCore::ContentExtensions::DFANode::bestFallbackTarget const):

  • contentextensions/ImmutableNFANodeBuilder.h:
  • contentextensions/NFA.cpp:

(WebCore::ContentExtensions::NFA::debugPrintDot const):

  • contentextensions/NFANode.h:
  • contentextensions/NFAToDFA.cpp:

(WebCore::ContentExtensions::NodeIdSetToUniqueNodeIdSetSource::NodeIdSetToUniqueNodeIdSetSource):
(WebCore::ContentExtensions::NodeIdSetToUniqueNodeIdSetTranslator::translate):

  • css/makeprop.pl:
  • css/parser/CSSParserContext.h:
  • dom/GCReachableRef.h:
  • dom/MessagePortIdentifier.h:
  • dom/NodeRareData.h:

(WebCore::NodeListsNodeData::NodeListCacheMapEntryHash::hash):
(WebCore::NodeListsNodeData::NodeListCacheMapEntryHash::equal):

  • dom/QualifiedName.h:
  • history/BackForwardItemIdentifier.h:
  • html/canvas/WebGLRenderingContextBase.h:
  • layout/LayoutUnits.h:
  • loader/AdClickAttribution.h:
  • loader/ResourceCryptographicDigest.h:

(WTF::DefaultHash<WebCore::ResourceCryptographicDigest>::hash):
(WTF::DefaultHash<WebCore::ResourceCryptographicDigest>::equal):
(WTF::DefaultHash<WebCore::ResourceCryptographicDigest>::Hash::hash): Deleted.
(WTF::DefaultHash<WebCore::ResourceCryptographicDigest>::Hash::equal): Deleted.

  • page/ClientOrigin.h:
  • page/GlobalWindowIdentifier.h:
  • page/SecurityOriginData.h:
  • page/SecurityOriginHash.h:
  • platform/Cookie.h:
  • platform/RegistrableDomain.h:
  • platform/graphics/ColorHash.h:
  • platform/graphics/FloatSizeHash.h:

(WTF::FloatHash<WebCore::FloatSize>::hash):

  • platform/graphics/FontGenericFamilies.h:
  • platform/graphics/IntPointHash.h:
  • platform/graphics/IntRectHash.h:

(WTF::IntHash<WebCore::IntRect>::hash):
(WTF::IntHash<WebCore::IntRect>::equal):

  • platform/graphics/IntSizeHash.h:
  • platform/graphics/WidthCache.h:
  • platform/graphics/freetype/FontCacheFreeType.cpp:

(WebCore::FallbackFontDescriptionKey::computeHash const):

  • platform/network/HTTPParsers.h:
  • platform/network/ProtectionSpaceHash.h:
  • platform/win/COMPtr.h:
  • platform/win/WindowsKeyNames.h:
  • rendering/CSSValueKey.h:
  • rendering/GridBaselineAlignment.h:
  • rendering/GridTrackSizingAlgorithm.h:
  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid const):

  • rendering/RenderTheme.h:
  • style/RuleSet.cpp:

(WebCore::Style::RuleSet::evaluateDynamicMediaQueryRules):

  • svg/SVGElement.h:

(WebCore::SVGAttributeHashTranslator::hash):

  • workers/service/ServiceWorkerClientIdentifier.h:
  • workers/service/ServiceWorkerRegistrationKey.h:

Source/WebCore/PAL:

  • pal/SessionID.h:

Source/WebKit:

  • NetworkProcess/Downloads/DownloadID.h:
  • NetworkProcess/cache/NetworkCache.h:
  • NetworkProcess/cache/NetworkCacheKey.h:
  • Platform/IPC/MessageReceiverMap.h:
  • Platform/IPC/StringReference.h:
  • Shared/CallbackID.h:
  • UIProcess/API/cpp/WKRetainPtr.h:

Source/WebKitLegacy/win:

  • COMPropertyBag.h:

Source/WTF:

DefaultHash<T> doesn't need to have a inner struct Hash. This can
be a problem for forward declarations (Bug 214320 Comment 5).

  • wtf/BitVector.h:
  • wtf/Forward.h:
  • wtf/HashFunctions.h:

(WTF::PairHash::hash):
(WTF::PairHash::equal):
(WTF::TupleHash::hash):
(WTF::TupleHash::equal):

  • wtf/ListHashSet.h:
  • wtf/LoggingHashMap.h:
  • wtf/LoggingHashSet.h:
  • wtf/MetaAllocatorPtr.h:
  • wtf/ObjectIdentifier.h:
  • wtf/OptionSetHash.h:

(WTF::DefaultHash<OptionSet<T>>::hash):
(WTF::DefaultHash<OptionSet<T>>::equal):
(WTF::DefaultHash<OptionSet<T>>::Hash::hash): Deleted.
(WTF::DefaultHash<OptionSet<T>>::Hash::equal): Deleted.

  • wtf/Packed.h:
  • wtf/RetainPtr.h:
  • wtf/StackShot.h:
  • wtf/URLHash.h:
  • wtf/VectorHash.h:

(WTF::VectorHash::hash):

  • wtf/text/AtomString.h:
  • wtf/text/AtomStringHash.h:
  • wtf/text/CString.h:
  • wtf/text/StringHash.h:
  • wtf/text/StringImpl.h:
  • wtf/text/SymbolRegistry.h:

(WTF::DefaultHash<SymbolRegistryKey>::hash):
(WTF::DefaultHash<SymbolRegistryKey>::equal):
(WTF::DefaultHash<SymbolRegistryKey>::Hash::hash): Deleted.
(WTF::DefaultHash<SymbolRegistryKey>::Hash::equal): Deleted.

  • wtf/text/WTFString.h:

Tools:

  • TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h:

(WTF::DefaultHash<DeletedAddressOfOperator>::hash):
(WTF::DefaultHash<DeletedAddressOfOperator>::equal):
(WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash): Deleted.
(WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal): Deleted.

  • TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:

(TestWebKitAPI::bucketForKey):

  • TestWebKitAPI/Tests/WTF/HashMap.cpp:

(TestWebKitAPI::bucketForKey):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WTF/HashSet.cpp:

(TestWebKitAPI::testInitialCapacity):

  • TestWebKitAPI/Tests/WTF/MoveOnly.h:

(WTF::DefaultHash<MoveOnly>::hash):
(WTF::DefaultHash<MoveOnly>::equal):
(WTF::DefaultHash<MoveOnly>::Hash::hash): Deleted.
(WTF::DefaultHash<MoveOnly>::Hash::equal): Deleted.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/parser/VariableEnvironment.h

    r262613 r264488  
    328328
    329329template<typename T> struct DefaultHash;
    330 template<> struct DefaultHash<JSC::CompactVariableMapKey> {
    331     using Hash = JSC::CompactVariableMapKey;
    332 };
     330template<> struct DefaultHash<JSC::CompactVariableMapKey> : JSC::CompactVariableMapKey { };
    333331
    334332template<> struct HashTraits<JSC::CompactVariableMapKey> : GenericHashTraits<JSC::CompactVariableMapKey> {
Note: See TracChangeset for help on using the changeset viewer.