Changeset 26475 in webkit for trunk/JavaScriptCore/kjs/array_object.cpp

Timestamp:

Oct 12, 2007, 7:43:04 AM (18 years ago)

Author:

oliver

Message:

Reviewed by Oliver.

• skip extra hash lookup and avoid converting char* to UString for 19% speedup on CK JS array test ​http://bugs.webkit.org/show_bug.cgi?id=15350

• kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): Implement the two mentioned optimizations.

File:

• trunk/JavaScriptCore/kjs/array_object.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/array_object.cpp

@@ -536 +536 @@
   case Join: {
     static HashSet<JSObject*> visitedElems;
-    if (visitedElems.contains(thisObj))
-        return jsString("");
-    UString separator = ",";
-    UString str = "";
-
-    visitedElems.add(thisObj);
+    static const UString empty("");
+    static const UString comma(",");
+    bool alreadyVisited = !visitedElems.add(thisObj).second;
+    if (alreadyVisited)
+        return jsString(empty);
+    UString separator = comma;
+    UString str = empty;
+
     if (id == Join && !args[0]->isUndefined())
         separator = args[0]->toString(exec);