Changeset 265297 in webkit for trunk/Source/JavaScriptCore/runtime/VM.cpp

Timestamp:

Aug 5, 2020, 12:12:00 PM (5 years ago)

Author:

[email protected]

Message:

Add assertions / inline capacity to checkpoint side state stacks
​https://bugs.webkit.org/show_bug.cgi?id=215175

Reviewed by Saam Barati.

The inline capacity should hopefully avoid unneeded mallocs close to 100% of the time during our OSR exit ramp.

• dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::compileExit):

• ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

• runtime/VM.cpp:

(JSC::VM::pushCheckpointOSRSideState):

• runtime/VM.h:

File:

• trunk/Source/JavaScriptCore/runtime/VM.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/VM.cpp

@@ -1095 +1095 @@
 #endif
     m_checkpointSideState.append(WTFMove(payload));
+
+#if ASSERT_ENABLED
+    auto bounds = StackBounds::currentThreadStackBounds();
+    void* previousCallFrame = bounds.end();
+    for (size_t i = m_checkpointSideState.size(); i--;) {
+        auto* callFrame = m_checkpointSideState[i]->associatedCallFrame;
+        if (!bounds.contains(callFrame))
+            break;
+        ASSERT(previousCallFrame < callFrame);
+        previousCallFrame = callFrame;
+    }
+#endif
 }