Changeset 26619 in webkit for trunk/JavaScriptCore

Timestamp:

Oct 15, 2007, 1:40:50 PM (18 years ago)

Author:

ggaren

Message:

JavaScriptCore:

Reviewed by Darin Adler.

Made function parameters DontDelete. This matches FF and the vague
description in ECMA 10.1.3. It's also required in order to make
symbol table based lookup of function parameters valid. (If the
parameters aren't DontDelete, you can't guarantee that you'll find
them later in the symbol table.)

[ Patch broken off from ​http://bugs.webkit.org/show_bug.cgi?id=14868 ]

• kjs/function.cpp: (KJS::FunctionImp::passInParameters):

LayoutTests:

Committed revision 26618.

Made function parameters DontDelete.

• fast/js/delete-function-parameter-expected.txt: Added.
• fast/js/delete-function-parameter.html: Added.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• kjs/function.cpp (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2007-10-15  Geoffrey Garen  <[email protected]>
+
+        Reviewed by Darin Adler.
+        
+        Made function parameters DontDelete. This matches FF and the vague
+        description in ECMA 10.1.3. It's also required in order to make
+        symbol table based lookup of function parameters valid. (If the 
+        parameters aren't DontDelete, you can't guarantee that you'll find
+        them later in the symbol table.)
+
+        [ Patch broken off from http://bugs.webkit.org/show_bug.cgi?id=14868 ]
+
+        * kjs/function.cpp:
+        (KJS::FunctionImp::passInParameters):
+
 2007-10-15  Geoffrey Garen  <[email protected]>
 

trunk/JavaScriptCore/kjs/function.cpp

@@ -167 +167 @@
       printInfo(exec, "to", args[i]);
 #endif
-      variable->put(exec, parameters[i].name, args[i]);
+      variable->put(exec, parameters[i].name, args[i], DontDelete);
     }
 }