Changeset 26620 in webkit for trunk/JavaScriptCore

Timestamp:

Oct 15, 2007, 1:41:39 PM (18 years ago)

Author:

ggaren

Message:

Reviewed by Darin Adler.

Removed the concept of AnonymousCode. It was unused, and it doesn't
exist in the ECMA spec.

[ Patch broken off from ​http://bugs.webkit.org/show_bug.cgi?id=14868 ]

• kjs/Context.cpp: (KJS::Context::Context):
• kjs/function.h: (KJS::):
• kjs/nodes.cpp: (ReturnNode::execute):

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• kjs/Context.cpp (modified) (2 diffs)
• kjs/function.h (modified) (1 diff)
• kjs/nodes.cpp (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2007-10-15  Geoffrey Garen  <[email protected]>
+
+        Reviewed by Darin Adler.
+        
+        Removed the concept of AnonymousCode. It was unused, and it doesn't
+        exist in the ECMA spec.
+        
+        [ Patch broken off from http://bugs.webkit.org/show_bug.cgi?id=14868 ]
+
+        * kjs/Context.cpp:
+        (KJS::Context::Context):
+        * kjs/function.h:
+        (KJS::):
+        * kjs/nodes.cpp:
+        (ReturnNode::execute):
+
 2007-10-15  Geoffrey Garen  <[email protected]>
 

trunk/JavaScriptCore/kjs/Context.cpp

@@ -43 +43 @@
     
     // create and initialize activation object (ECMA 10.1.6)
-    if (type == FunctionCode || type == AnonymousCode ) {
+    if (type == FunctionCode) {
         m_activation = new ActivationImp(func, *args);
         m_variable = m_activation;
@@ -66 +66 @@
         break;
     case FunctionCode:
-    case AnonymousCode:
-        if (type == FunctionCode) {
-            scope = func->scope();
-            scope.push(m_activation);
-        } else {
-            scope.clear();
-            scope.push(glob);
-            scope.push(m_activation);
-        }
+        scope = func->scope();
+        scope.push(m_activation);
         m_variable = m_activation; // TODO: DontDelete ? (ECMA 10.2.3)
         m_thisVal = thisV;
         break;
     }
-    
+
     m_interpreter->setContext(this);
 }

trunk/JavaScriptCore/kjs/function.h

@@ -35 +35 @@
   class FunctionPrototype;
 
-  enum CodeType { GlobalCode,
-                  EvalCode,
-                  FunctionCode,
-                  AnonymousCode };
+  enum CodeType {
+      GlobalCode,
+      EvalCode,
+      FunctionCode,
+  };
 
   class InternalFunctionImp : public JSObject {

trunk/JavaScriptCore/kjs/nodes.cpp

@@ -2108 +2108 @@
 
   CodeType codeType = exec->context()->codeType();
-  if (codeType != FunctionCode && codeType != AnonymousCode ) {
+  if (codeType != FunctionCode)
     return createErrorCompletion(exec, SyntaxError, "Invalid return statement.");
-  }
 
   if (!value)