Changeset 266223 in webkit for trunk/Source/JavaScriptCore/runtime/Operations.cpp

Timestamp:

Aug 26, 2020, 10:27:16 PM (5 years ago)

Author:

Alexey Shvayka

Message:

Use jsTypeofIsObject() in DFG AI and operationTypeOfIsObject()
​https://bugs.webkit.org/show_bug.cgi?id=144457

Reviewed by Saam Barati.

Source/JavaScriptCore:

This patch refactors jsTypeofIsObject(), leveraging fast path of isCallable(),
moves it to the header, and utilizes it in operationTypeOfIsObject() & DFG AI
(minding concurrency) to eliminate code duplication.

Also, removes orphaned slow_path_is_object declaration.

No behavior change, typeof microbenchmarks are neutral.

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGOperations.cpp:
• runtime/CommonSlowPaths.h:
• runtime/Operations.cpp:

(JSC::jsTypeofIsObject): Deleted.

• runtime/Operations.h:

(JSC::jsTypeofIsObjectWithConcurrency):
(JSC::jsTypeofIsObject):

Source/WTF:

• wtf/TriState.h:

(WTF::invert):

File:

• trunk/Source/JavaScriptCore/runtime/Operations.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/Operations.cpp

@@ -114 +114 @@
 }
 
-bool jsTypeofIsObject(JSGlobalObject* globalObject, JSValue v)
-{
-    VM& vm = globalObject->vm();
-    if (!v.isCell())
-        return v.isNull();
-
-    JSType type = v.asCell()->type();
-    if (type == StringType || type == SymbolType || type == HeapBigIntType)
-        return false;
-    if (type >= ObjectType) {
-        if (asObject(v)->structure(vm)->masqueradesAsUndefined(globalObject))
-            return false;
-        JSObject* object = asObject(v);
-        if (object->isCallable(vm))
-            return false;
-    }
-    return true;
-}
-
 size_t normalizePrototypeChain(JSGlobalObject* globalObject, JSCell* base, bool& sawPolyProto)
 {