Changeset 266250 in webkit for trunk/Source/JavaScriptCore/runtime/JSBigInt.cpp

Timestamp:

Aug 27, 2020, 1:01:04 PM (5 years ago)

Author:

[email protected]

Message:

[JSC] Use auxiliary memory for JSBigInt storage
​https://bugs.webkit.org/show_bug.cgi?id=215876

Reviewed by Mark Lam.

This makes JSBigInt non-destructible cell. And it makes allocating JSBigInt from JIT easy.

• runtime/JSBigInt.cpp:

(JSC::JSBigInt::JSBigInt):
(JSC::JSBigInt::visitChildren):
(JSC::JSBigInt::createWithLength):
(JSC::JSBigInt::destroy): Deleted.

• runtime/JSBigInt.h:
• runtime/VM.cpp:

(JSC::VM::VM):

File:

• trunk/Source/JavaScriptCore/runtime/JSBigInt.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/runtime/JSBigInt.cpp

@@ -64 +64 @@
     : Base(vm, structure)
     , m_length(length)
-    , m_data(data, length)
+    , m_data(vm, this, data, length)
 { }
 
-void JSBigInt::destroy(JSCell* thisCell)
-{
-    static_cast<JSBigInt*>(thisCell)->~JSBigInt();
+void JSBigInt::visitChildren(JSCell* cell, SlotVisitor& visitor)
+{
+    auto* thisObject = jsCast<JSBigInt*>(cell);
+    ASSERT_GC_OBJECT_INHERITS(thisObject, info());
+    Base::visitChildren(thisObject, visitor);
+    if (auto* data = thisObject->m_data.getUnsafe())
+        visitor.markAuxiliary(data);
 }
 
@@ -109 +113 @@
 
     ASSERT(length <= maxLength);
-    void* data = Gigacage::tryMalloc(Gigacage::Primitive, length * sizeof(Digit));
+    void* data = vm.primitiveGigacageAuxiliarySpace.allocateNonVirtual(vm, length * sizeof(Digit), nullptr, AllocationFailureMode::ReturnNull);
     if (UNLIKELY(!data)) {
         if (nullOrGlobalObjectForOOM) {