Changeset 266251 in webkit for trunk/Source/JavaScriptCore/runtime/JSCJSValue.h

Timestamp:

Aug 27, 2020, 1:11:57 PM (5 years ago)

Author:

[email protected]

Message:

structureOrNull should take VM instead of getting it from the marked block
​https://bugs.webkit.org/show_bug.cgi?id=215899

Reviewed by Yusuke Suzuki.

It's slightly faster use an existing VM over recomputing the address. It probably doesn't
happen to matter here for performance but it's good hygiene.

• API/tests/JSWrapperMapTests.mm:

(+[JSWrapperMapTests testStructureIdentity]):

• jit/JITOperations.cpp:
• runtime/JSCJSValue.h:
• runtime/JSCJSValueInlines.h:

(JSC::JSValue::structureOrNull const):
(JSC::JSValue::structureOrUndefined const): Deleted.

File:

• trunk/Source/JavaScriptCore/runtime/JSCJSValue.h (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/JSCJSValue.h

@@ -339 +339 @@
     JS_EXPORT_PRIVATE bool isValidCallee();
 
-    Structure* structureOrNull() const;
-    JSValue structureOrUndefined() const;
+    Structure* structureOrNull(VM&) const;
 
     JS_EXPORT_PRIVATE void dump(PrintStream&) const;