Changeset 266251 in webkit for trunk/Source/JavaScriptCore/runtime/JSCJSValueInlines.h

Timestamp:

Aug 27, 2020, 1:11:57 PM (5 years ago)

Author:

[email protected]

Message:

structureOrNull should take VM instead of getting it from the marked block
​https://bugs.webkit.org/show_bug.cgi?id=215899

Reviewed by Yusuke Suzuki.

It's slightly faster use an existing VM over recomputing the address. It probably doesn't
happen to matter here for performance but it's good hygiene.

• API/tests/JSWrapperMapTests.mm:

(+[JSWrapperMapTests testStructureIdentity]):

• jit/JITOperations.cpp:
• runtime/JSCJSValue.h:
• runtime/JSCJSValueInlines.h:

(JSC::JSValue::structureOrNull const):
(JSC::JSValue::structureOrUndefined const): Deleted.

File:

• trunk/Source/JavaScriptCore/runtime/JSCJSValueInlines.h (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/JSCJSValueInlines.h

@@ -1106 +1106 @@
 }
 
-inline Structure* JSValue::structureOrNull() const
+inline Structure* JSValue::structureOrNull(VM& vm) const
 {
     if (isCell())
-        return asCell()->structure();
+        return asCell()->structure(vm);
     return nullptr;
-}
-
-inline JSValue JSValue::structureOrUndefined() const
-{
-    if (isCell())
-        return JSValue(asCell()->structure());
-    return jsUndefined();
 }