Changeset 266318 in webkit for trunk/Source/JavaScriptCore

Timestamp:

Aug 28, 2020, 7:26:40 PM (5 years ago)

Author:

[email protected]

Message:

[JSC] new import.meta() is acceptable
​https://bugs.webkit.org/show_bug.cgi?id=215915

Reviewed by Ross Kirsling.

JSTests:

• stress/modules-syntax-error.js:
• stress/modules-syntax.js:
• test262/expectations.yaml:

Source/JavaScriptCore:

new import.meta() is valid in terms of syntax while it throws runtime error.
We should accept this code, while new import() is not correct syntax.

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseMemberExpression):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• parser/Parser.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-08-28  Yusuke Suzuki  <[email protected]>
+
+        [JSC] `new import.meta()` is acceptable
+        https://bugs.webkit.org/show_bug.cgi?id=215915
+
+        Reviewed by Ross Kirsling.
+
+        `new import.meta()` is valid in terms of syntax while it throws runtime error.
+        We should accept this code, while `new import()` is not correct syntax.
+
+        * parser/Parser.cpp:
+        (JSC::Parser<LexerType>::parseMemberExpression):
+
 2020-08-27  Alexey Shvayka  <[email protected]>
 

trunk/Source/JavaScriptCore/parser/Parser.cpp

@@ -4844 +4844 @@
     bool previousBaseWasSuper = false;
     bool baseIsImport = match(IMPORT);
-    semanticFailIfTrue((baseIsSuper || baseIsImport) && newCount, "Cannot use new with ", getToken());
+    semanticFailIfTrue(baseIsSuper && newCount, "Cannot use new with ", getToken());
 
     bool baseIsNewTarget = false;
@@ -4904 +4904 @@
             }
         } else {
+            semanticFailIfTrue(newCount, "Cannot use new with import");
             consumeOrFail(OPENPAREN, "import call expects exactly one argument");
             TreeExpression expr = parseAssignmentExpression(context);