Changeset 266322 in webkit for trunk/Source/JavaScriptCore

Timestamp:

Aug 29, 2020, 12:11:42 AM (5 years ago)

Author:

[email protected]

Message:

[JSC] super property with new should be accepted
​https://bugs.webkit.org/show_bug.cgi?id=215966

Reviewed by Ross Kirsling.

JSTests:

• stress/super-and-new.js: Added.

(testSyntaxError):
(shouldBe):
(test.A):
(test.A.prototype.get hey):
(test.A.prototype.get hey2):
(test.A.prototype.super):
(test.B.get super):

Source/JavaScriptCore:

While we should reject new super / new super(), we should accept new super.property.
​https://tc39.es/ecma262/#prod-SuperProperty is a child production of ​https://tc39.es/ecma262/#prod-MemberExpression,
unlike ​https://tc39.es/ecma262/#prod-SuperCall. So new should accept SuperProperty (e.g. super.xxx).

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseMemberExpression):

LayoutTests:

• js/class-syntax-super-expected.txt:
• js/script-tests/class-syntax-super.js:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• parser/Parser.cpp (modified) (3 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-08-28  Yusuke Suzuki  <[email protected]>
+
+        [JSC] super property with new should be accepted
+        https://bugs.webkit.org/show_bug.cgi?id=215966
+
+        Reviewed by Ross Kirsling.
+
+        While we should reject `new super` / `new super()`, we should accept `new super.property`.
+        https://tc39.es/ecma262/#prod-SuperProperty is a child production of https://tc39.es/ecma262/#prod-MemberExpression,
+        unlike https://tc39.es/ecma262/#prod-SuperCall. So `new` should accept SuperProperty (e.g. `super.xxx`).
+
+        * parser/Parser.cpp:
+        (JSC::Parser<LexerType>::parseMemberExpression):
+
 2020-08-28  Yusuke Suzuki  <[email protected]>
 

trunk/Source/JavaScriptCore/parser/Parser.cpp

@@ -4844 +4844 @@
     bool previousBaseWasSuper = false;
     bool baseIsImport = match(IMPORT);
-    semanticFailIfTrue(baseIsSuper && newCount, "Cannot use new with ", getToken());
 
     bool baseIsNewTarget = false;
@@ -4976 +4975 @@
                 if (newCount) {
                     newCount--;
+                    semanticFailIfTrue(baseIsSuper, "Cannot use new with super call");
                     JSTextPosition expressionEnd = lastTokenEndPosition();
                     TreeArguments arguments = parseArguments(context);
@@ -5072 +5072 @@
     } while (match(QUESTIONDOT));
 
-    semanticFailIfTrue(baseIsSuper, "super is not valid in this context");
+    semanticFailIfTrue(baseIsSuper, newCount ? "Cannot use new with super call" : "super is not valid in this context");
     while (newCount--)
         base = context.createNewExpr(location, base, expressionStart, lastTokenEndPosition());