Changeset 268037 in webkit for trunk/Source/JavaScriptCore/ChangeLog

Timestamp:

Oct 5, 2020, 11:31:06 PM (5 years ago)

Author:

Ross Kirsling

Message:

%TypedArray%.from must do mapping and putting in lockstep
​https://bugs.webkit.org/show_bug.cgi?id=217349

Reviewed by Yusuke Suzuki.

JSTests:

• test262/expectations.yaml:

Mark two test cases as passing.

Source/JavaScriptCore:

%TypedArray%.from first turns the input iterator into a list to find the size for the resulting typed array,
then it fills the typed array with the list elements.

If a map function is provided, however, it must be called during the *second* phase, not the first,
because if an element throws upon valueOf, that should prevent all further calls of the map function.

• builtins/TypedArrayConstructor.js:

(from):

File:

• trunk/Source/JavaScriptCore/ChangeLog (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-10-05  Ross Kirsling  <[email protected]>
+
+        %TypedArray%.from must do mapping and putting in lockstep
+        https://bugs.webkit.org/show_bug.cgi?id=217349
+
+        Reviewed by Yusuke Suzuki.
+
+        %TypedArray%.from first turns the input iterator into a list to find the size for the resulting typed array,
+        then it fills the typed array with the list elements.
+
+        If a map function is provided, however, it must be called during the *second* phase, not the first,
+        because if an element throws upon valueOf, that should prevent all further calls of the map function.
+
+        * builtins/TypedArrayConstructor.js:
+        (from):
+
 2020-10-05  Yusuke Suzuki  <[email protected]>