Changeset 26808 in webkit for trunk/JavaScriptCore/kjs/function.cpp

Timestamp:

Oct 19, 2007, 10:18:23 PM (18 years ago)

Author:

ggaren

Message:

Reviewed by Darin Adler.

To improve encapsulation, moved processDeclarations call into
FunctionBodyNode::execute. Also marked processDeclarations
ALWAYS_INLINE, since it has only 1 caller now. This is a .71% speedup
on command-line JS iBench.

• kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::GlobalFuncImp::callAsFunction):
• kjs/function.h:
• kjs/interpreter.cpp: (KJS::Interpreter::evaluate):
• kjs/nodes.cpp: (FunctionBodyNode::execute):
• kjs/nodes.h:

File:

• trunk/JavaScriptCore/kjs/function.cpp (modified) (3 diffs)

trunk/JavaScriptCore/kjs/function.cpp

@@ -77 +77 @@
 
   passInParameters(&newExec, args);
-  processVarDecls(&newExec);
 
   Debugger* dbg = exec->dynamicInterpreter()->debugger();
@@ -270 +269 @@
       return result;
   return Completion(Normal, jsUndefined()); // TODO: or ReturnValue ?
-}
-
-void FunctionImp::processVarDecls(ExecState* exec)
-{
-    body->processDeclarations(exec);
 }
 
@@ -782 +776 @@
         }
         
-        // execute the code
-        progNode->processDeclarations(&newExec);
         Completion c = progNode->execute(&newExec);