Changeset 26808 in webkit for trunk/JavaScriptCore/kjs/nodes.h

Timestamp:

Oct 19, 2007, 10:18:23 PM (18 years ago)

Author:

ggaren

Message:

Reviewed by Darin Adler.

To improve encapsulation, moved processDeclarations call into
FunctionBodyNode::execute. Also marked processDeclarations
ALWAYS_INLINE, since it has only 1 caller now. This is a .71% speedup
on command-line JS iBench.

• kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::GlobalFuncImp::callAsFunction):
• kjs/function.h:
• kjs/interpreter.cpp: (KJS::Interpreter::evaluate):
• kjs/nodes.cpp: (FunctionBodyNode::execute):
• kjs/nodes.h:

File:

• trunk/JavaScriptCore/kjs/nodes.h (modified) (4 diffs)

trunk/JavaScriptCore/kjs/nodes.h

@@ -815 +815 @@
     JSValue* evaluate(ExecState*) KJS_FAST_CALL;
     virtual void streamTo(SourceStream&) const KJS_FAST_CALL;
-    void ALWAYS_INLINE processDeclaration(ExecState*) KJS_FAST_CALL;
+    ALWAYS_INLINE void processDeclaration(ExecState*) KJS_FAST_CALL;
     virtual void getDeclarations(DeclarationStacks&) KJS_FAST_CALL;
   private:
@@ -1044 +1044 @@
     int sourceId() KJS_FAST_CALL { return m_sourceId; }
     const UString& sourceURL() KJS_FAST_CALL { return m_sourceURL; }
+
+    virtual Completion execute(ExecState*) KJS_FAST_CALL;
 
     void addParam(const Identifier& ident) KJS_FAST_CALL;
@@ -1050 +1052 @@
     UString paramString() const KJS_FAST_CALL;
     Vector<Identifier>& parameters() KJS_FAST_CALL { return m_parameters; }
-    void processDeclarations(ExecState*) KJS_FAST_CALL;
+    ALWAYS_INLINE void processDeclarations(ExecState*) KJS_FAST_CALL;
   private:
     UString m_sourceURL;
@@ -1081 +1083 @@
     virtual void streamTo(SourceStream&) const KJS_FAST_CALL;
     virtual void getDeclarations(DeclarationStacks&) KJS_FAST_CALL;
-    void ALWAYS_INLINE processDeclaration(ExecState*) KJS_FAST_CALL;
+    ALWAYS_INLINE void processDeclaration(ExecState*) KJS_FAST_CALL;
   private:
     void addParams() KJS_FAST_CALL;