Changeset 268241 in webkit for trunk/Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h

Timestamp:

Oct 8, 2020, 6:18:14 PM (5 years ago)

Author:

[email protected]

Message:

Unreviewed, reverting r268170 and r268190.
​https://bugs.webkit.org/show_bug.cgi?id=217502

Crash on ARM64E exclusively

Reverted changesets:

"[JSC] Restrict more ptr-tagging and avoid using
OperationPtrTag for JIT code"
​https://bugs.webkit.org/show_bug.cgi?id=217460
​https://trac.webkit.org/changeset/268170

"Unreviewed, build fix for ARM64E"
​https://bugs.webkit.org/show_bug.cgi?id=217460
​https://trac.webkit.org/changeset/268190

File:

• trunk/Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h

@@ -279 +279 @@
 #endif
     {
-        assertIsTaggedWith<tag>(value);
+        assertIsTaggedWith(value, tag);
         ASSERT(value);
 #if CPU(ARM_THUMB2)
@@ -291 +291 @@
         ASSERT(value);
         ASSERT_VALID_CODE_POINTER(value);
-        assertIsTaggedWith<tag>(value);
+        assertIsTaggedWith(value, tag);
         MacroAssemblerCodePtr result;
         result.m_value = value;