Changeset 268241 in webkit for trunk/Source/JavaScriptCore/runtime/PutPropertySlot.h

Timestamp:

Oct 8, 2020, 6:18:14 PM (5 years ago)

Author:

[email protected]

Message:

Unreviewed, reverting r268170 and r268190.
​https://bugs.webkit.org/show_bug.cgi?id=217502

Crash on ARM64E exclusively

Reverted changesets:

"[JSC] Restrict more ptr-tagging and avoid using
OperationPtrTag for JIT code"
​https://bugs.webkit.org/show_bug.cgi?id=217460
​https://trac.webkit.org/changeset/268170

"Unreviewed, build fix for ARM64E"
​https://bugs.webkit.org/show_bug.cgi?id=217460
​https://trac.webkit.org/changeset/268190

File:

• trunk/Source/JavaScriptCore/runtime/PutPropertySlot.h (modified) (4 diffs)

trunk/Source/JavaScriptCore/runtime/PutPropertySlot.h

@@ -67 +67 @@
     }
 
-    void setCustomValue(JSObject* base, PutValueFunc function)
+    void setCustomValue(JSObject* base, FunctionPtr<OperationPtrTag> function)
     {
         m_type = CustomValue;
@@ -74 +74 @@
     }
 
-    void setCustomAccessor(JSObject* base, PutValueFunc function)
+    void setCustomAccessor(JSObject* base, FunctionPtr<OperationPtrTag> function)
     {
         m_type = CustomAccessor;
@@ -98 +98 @@
     }
 
-    FunctionPtr<PutValuePtrTag> customSetter() const
+    FunctionPtr<OperationPtrTag> customSetter() const
     {
         ASSERT(isCacheableCustom());
@@ -138 +138 @@
     uint8_t m_context;
     CacheabilityType m_cacheability;
-    FunctionPtr<PutValuePtrTag> m_putFunction;
+    FunctionPtr<OperationPtrTag> m_putFunction;
 };