Changeset 26847 in webkit for trunk/JavaScriptCore/kjs/property_map.cpp

Timestamp:

Oct 21, 2007, 8:12:08 AM (18 years ago)

Author:

darin

Message:

Reviewed by Maciej.

• ​http://bugs.webkit.org/show_bug.cgi?id=15585 speed up sparse arrays by using a custom map

Speeds up SunSpider by 10%.

• kjs/array_object.cpp: (allocateStorage): Leave room for an additional pointer. (reallocateStorage): Ditto. (freeStorage): Ditto. (ArrayInstance::~ArrayInstance): Delete the overflow map if present. (ArrayInstance::getItem): Read values from the overflow map if present. Removed the check of length, since it slows down the common case. (ArrayInstance::getOwnPropertySlot): Ditto. Also removed the fallback to the property map. (ArrayInstance::put): Write values into the overflow map as needed. Also create overflow map when needed. (ArrayInstance::deleteProperty): Remove values from the overflow map as appropriate. (ArrayInstance::getPropertyNames): Add a name for each identifier in the property map. This is extremely inefficient. (ArrayInstance::setLength): Remove any values in the overflow map that are past the new length, as we formerly did with the property map. (ArrayInstance::mark): Mark any values in the overflow map. (compareByStringForQSort): Removed unneeded undefined case, since compactForSorting guarantees we will have no undefined values. (compareWithCompareFunctionForQSort): Ditto. (ArrayInstance::compactForSorting): Copy all the values out of the overflow map and destroy it.

• kjs/property_map.h: Removed now-unused getSparseArrayPropertyNames.
• kjs/property_map.cpp: Ditto.

File:

• trunk/JavaScriptCore/kjs/property_map.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/property_map.cpp

@@ -621 +621 @@
 }
 
-void PropertyMap::getSparseArrayPropertyNames(PropertyNameArray& propertyNames) const
-{
-    if (!m_usingTable) {
-#if USE_SINGLE_ENTRY
-        UString::Rep *key = m_singleEntryKey;
-        if (key) {
-            UString k(key);
-            bool fitsInUInt32;
-            k.toUInt32(&fitsInUInt32);
-            if (fitsInUInt32)
-                propertyNames.add(Identifier(key));
-        }
-#endif
-        return;
-    }
-
-    int size = m_u.table->size;
-    Entry *entries = m_u.table->entries;
-    for (int i = 0; i != size; ++i) {
-        UString::Rep *key = entries[i].key;
-        if (isValid(key)) {
-            UString k(key);
-            bool fitsInUInt32;
-            k.toUInt32(&fitsInUInt32);
-            if (fitsInUInt32)
-                propertyNames.add(Identifier(key));
-        }
-    }
-}
-
 void PropertyMap::save(SavedProperties &p) const
 {