Changeset 268599 in webkit for trunk/Source/WebCore/css/CSSStyleDeclaration.cpp

Timestamp:

Oct 16, 2020, 11:29:40 AM (5 years ago)

Author:

[email protected]

Message:

ENABLE_LEGACY_CSS_VENDOR_PREFIXES and RuntimeEnabledFeatures::legacyCSSVendorPrefixesEnabled() don't do anything
​https://bugs.webkit.org/show_bug.cgi?id=217833

Reviewed by Simon Fraser.

Source/WebCore:

Remove support for ENABLE_LEGACY_CSS_VENDOR_PREFIXES, which only guarded code
that also checked legacyCSSVendorPrefixesEnabled(), which was never enabled.

• css/CSSStyleDeclaration.cpp:
• css/parser/CSSPropertyParser.cpp:

(WebCore::cssPropertyID):

• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setLegacyCSSVendorPrefixesEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::legacyCSSVendorPrefixesEnabled const): Deleted.

Source/WTF:

• wtf/PlatformEnable.h:
• wtf/PlatformEnableCocoa.h:

Remove support for ENABLE_LEGACY_CSS_VENDOR_PREFIXES, which only guarded code that was always disabled.

File:

• trunk/Source/WebCore/css/CSSStyleDeclaration.cpp (modified) (4 diffs)

trunk/Source/WebCore/css/CSSStyleDeclaration.cpp

@@ -32 +32 @@
 #include "Document.h"
 #include "HashTools.h"
-#include "RuntimeEnabledFeatures.h"
 #include "Settings.h"
 #include "StyledElement.h"
@@ -46 +45 @@
 
 enum class PropertyNamePrefix {
-    None, Epub, CSS, Pixel, Pos, WebKit,
-#if ENABLE(LEGACY_CSS_VENDOR_PREFIXES)
-    Apple, KHTML,
-#endif
+    None,
+    Epub,
+    CSS,
+    Pixel,
+    Pos,
+    WebKit
 };
 
@@ -90 +91 @@
     UChar firstChar = toASCIILower(propertyName[0]);
     switch (firstChar) {
-#if ENABLE(LEGACY_CSS_VENDOR_PREFIXES)
-    case 'a':
-        if (RuntimeEnabledFeatures::sharedFeatures().legacyCSSVendorPrefixesEnabled() && matchesCSSPropertyNamePrefix(propertyName, "apple"))
-            return PropertyNamePrefix::Apple;
-        break;
-#endif
     case 'c':
         if (matchesCSSPropertyNamePrefix(propertyName, "css"))
             return PropertyNamePrefix::CSS;
         break;
-#if ENABLE(LEGACY_CSS_VENDOR_PREFIXES)
-    case 'k':
-        if (RuntimeEnabledFeatures::sharedFeatures().legacyCSSVendorPrefixesEnabled() && matchesCSSPropertyNamePrefix(propertyName, "khtml"))
-            return PropertyNamePrefix::KHTML;
-        break;
-#endif
     case 'e':
         if (matchesCSSPropertyNamePrefix(propertyName, "epub"))
@@ -198 +187 @@
         hadPixelOrPosPrefix = true;
         break;
-#if ENABLE(LEGACY_CSS_VENDOR_PREFIXES)
-    case PropertyNamePrefix::Apple:
-    case PropertyNamePrefix::KHTML:
-        ASSERT(RuntimeEnabledFeatures::sharedFeatures().legacyCSSVendorPrefixesEnabled());
-        writeWebKitPrefix(bufferPtr);
-        i += 5;
-        break;
-#endif
     case PropertyNamePrefix::Epub:
         writeEpubPrefix(bufferPtr);