Changeset 26893 in webkit for trunk/JavaScriptCore/kjs/JSImmediate.h

Timestamp:

Oct 22, 2007, 2:26:52 PM (18 years ago)

Author:

mjs

Message:

Reviewed by Oliver.

• Avoid moving floats into integer registers in jsNumber() for 3% speedup on SunSpider ​http://bugs.webkit.org/show_bug.cgi?id=15627

• kjs/JSImmediate.h: (KJS::JSImmediate::fromDouble): Avoid moving floats to integer registers since this is very slow.

File:

• trunk/JavaScriptCore/kjs/JSImmediate.h (modified) (1 diff)

trunk/JavaScriptCore/kjs/JSImmediate.h

@@ -155 +155 @@
 
         // check for data loss from conversion to float
-        DoubleUnion doubleUnion1, doubleUnion2;
-        doubleUnion1.asDouble = floatUnion.asFloat;
-        doubleUnion2.asDouble = d;
-        if (doubleUnion1.asBits != doubleUnion2.asBits)
+        // The d == d check is to allow NaN - it does not
+        // compare equal to itself, but we do want to allow it
+        if (floatUnion.asFloat != d && d == d)
             return 0;