Changeset 26897 in webkit for trunk/JavaScriptCore/kjs/array_instance.cpp

Timestamp:

Oct 22, 2007, 3:18:24 PM (18 years ago)

Author:

darin

Message:

Reviewed by Brady.

• fix crash seen when running JavaScriptCore tests

• kjs/array_instance.cpp: (KJS::ArrayInstance::mark): Copy and paste error: I accidentally had code here that was making a copy of the HashMap -- that's illegal inside a mark function and was unnecessary. The other callsite was modifying the map as it iterated it, but this function is not.

File:

• trunk/JavaScriptCore/kjs/array_instance.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/array_instance.cpp

@@ -422 +422 @@
 
     if (SparseArrayValueMap* map = storage->m_sparseValueMap) {
-        SparseArrayValueMap copy = *map;
-        SparseArrayValueMap::iterator end = copy.end();
-        for (SparseArrayValueMap::iterator it = copy.begin(); it != end; ++it) {
+        SparseArrayValueMap::iterator end = map->end();
+        for (SparseArrayValueMap::iterator it = map->begin(); it != end; ++it) {
             JSValue* value = it->second;
             if (!value->marked())