Changeset 26912 in webkit for trunk/JavaScriptCore/kjs/value.h

Timestamp:

Oct 22, 2007, 11:44:27 PM (18 years ago)

Author:

darin

Message:

Reviewed by Maciej.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=15636 some JavaScriptCore regression tests are failing due to numeric conversion

This should restore correctness and make speed better too, restoring some
of the optimization we lost in my last check-in.

• kjs/JSImmediate.h: (KJS::JSImmediate::getTruncatedInt32): Added. Uses the range checking idiom I used in my patch yesterday. (KJS::JSImmediate::getTruncatedUInt32): Ditto.

• kjs/internal.h: Removed getInt32 and added getTruncatedInt/UInt32.
• kjs/internal.cpp: (KJS::NumberImp::getUInt32): Changed to always use double, since I can't find a way to write this more efficiently for float. (KJS::NumberImp::getTruncatedInt32): Added. (KJS::NumberImp::getTruncatedUInt32): Added.

• kjs/value.h: Removed getInt32 and added getTruncatedInt/UInt32. (KJS::JSValue::getUInt32): (KJS::JSValue::getTruncatedInt32): Added. (KJS::JSValue::getTruncatedUInt32): Added. (KJS::JSValue::toInt32): Changed getInt32 call to getTruncatedInt32. (KJS::JSValue::toUInt32): Changed getUInt32 call to getTruncatedUInt32.
• kjs/value.cpp: (KJS::JSCell::getTruncatedInt32): Added. (KJS::JSCell::getTruncatedUInt32): Added. (KJS::JSValue::toInteger): Changed getUInt32 call to getTruncatedInt32. (KJS::JSValue::toInt32SlowCase): Removed extra getInt32 call I accidentally had left in here. (KJS::JSValue::toUInt32SlowCase): Ditto. (KJS::JSValue::toUInt16): Changed getUInt32 call to getTruncatedUInt32.

• JavaScriptCore.exp: Updated.

File:

• trunk/JavaScriptCore/kjs/value.h (modified) (7 diffs)

trunk/JavaScriptCore/kjs/value.h

@@ -77 +77 @@
 
     // Extracting integer values.
-    bool getInt32(int32_t&) const;
     bool getUInt32(uint32_t&) const;
+    bool getTruncatedInt32(int32_t&) const;
+    bool getTruncatedUInt32(uint32_t&) const;
 
     // Basic conversions.
@@ -141 +142 @@
 
     // Extracting integer values.
-    virtual bool getInt32(int32_t&) const;
     virtual bool getUInt32(uint32_t&) const;
+    virtual bool getTruncatedInt32(int32_t&) const;
+    virtual bool getTruncatedUInt32(uint32_t&) const;
 
     // Basic conversions.
@@ -333 +335 @@
 }
 
-inline bool JSValue::getInt32(int32_t& v) const
-{
-    return JSImmediate::isImmediate(this) ? JSImmediate::getInt32(this, v) : asCell()->getInt32(v);
-}
-
 inline bool JSValue::getUInt32(uint32_t& v) const
 {
     return JSImmediate::isImmediate(this) ? JSImmediate::getUInt32(this, v) : asCell()->getUInt32(v);
+}
+
+inline bool JSValue::getTruncatedInt32(int32_t& v) const
+{
+    return JSImmediate::isImmediate(this) ? JSImmediate::getTruncatedInt32(this, v) : asCell()->getTruncatedInt32(v);
+}
+
+inline bool JSValue::getTruncatedUInt32(uint32_t& v) const
+{
+    return JSImmediate::isImmediate(this) ? JSImmediate::getTruncatedUInt32(this, v) : asCell()->getTruncatedUInt32(v);
 }
 
@@ -387 +394 @@
 {
     int32_t i;
-    if (JSImmediate::isImmediate(this) && JSImmediate::getInt32(this, i))
+    if (JSImmediate::isImmediate(this) && JSImmediate::getTruncatedInt32(this, i))
         return i;
     bool ok;
@@ -396 +403 @@
 {
     uint32_t i;
-    if (JSImmediate::isImmediate(this) && JSImmediate::getUInt32(this, i))
+    if (JSImmediate::isImmediate(this) && JSImmediate::getTruncatedUInt32(this, i))
         return i;
     bool ok;
@@ -405 +412 @@
 {
     int32_t i;
-    if (JSImmediate::isImmediate(this) && JSImmediate::getInt32(this, i)) {
+    if (JSImmediate::isImmediate(this) && JSImmediate::getTruncatedInt32(this, i)) {
         ok = true;
         return i;
@@ -415 +422 @@
 {
     uint32_t i;
-    if (JSImmediate::isImmediate(this) && JSImmediate::getUInt32(this, i)) {
+    if (JSImmediate::isImmediate(this) && JSImmediate::getTruncatedUInt32(this, i)) {
         ok = true;
         return i;