Changeset 26959 in webkit for trunk/JavaScriptCore/kjs/object.cpp

Timestamp:

Oct 24, 2007, 1:21:21 AM (18 years ago)

Author:

darin

Message:

Reviewed by Eric.

• kjs/object.cpp: (KJS::JSObject::defaultValue): Get rid of a little Identifier ref/deref for what SunSpider claims is a 0.4% speedup.

File:

• trunk/JavaScriptCore/kjs/object.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/object.cpp

@@ -358 +358 @@
 JSValue* JSObject::defaultValue(ExecState* exec, JSType hint) const
 {
-  Identifier firstPropertyName;
-  Identifier secondPropertyName;
   /* Prefer String for Date objects */
   if ((hint == StringType) || (hint != StringType) && (hint != NumberType) && (_proto == exec->lexicalInterpreter()->builtinDatePrototype())) {
-    firstPropertyName = exec->propertyNames().toString;
-    secondPropertyName = exec->propertyNames().valueOf;
+    if (JSValue* v = tryGetAndCallProperty(exec, this, exec->propertyNames().toString))
+      return v;
+    if (JSValue* v = tryGetAndCallProperty(exec, this, exec->propertyNames().valueOf))
+      return v;
   } else {
-    firstPropertyName = exec->propertyNames().valueOf;
-    secondPropertyName = exec->propertyNames().toString;
-  }
-
-  JSValue *v;
-  if ((v = tryGetAndCallProperty(exec, this, firstPropertyName)))
-    return v;
-  if ((v = tryGetAndCallProperty(exec, this, secondPropertyName)))
-    return v;
+    if (JSValue* v = tryGetAndCallProperty(exec, this, exec->propertyNames().valueOf))
+      return v;
+    if (JSValue* v = tryGetAndCallProperty(exec, this, exec->propertyNames().toString))
+      return v;
+  }
 
   if (exec->hadException())