Changeset 26994 in webkit for trunk/JavaScriptCore/kjs/identifier.h

Timestamp:

Oct 24, 2007, 11:02:07 AM (18 years ago)

Author:

ggaren

Message:

Reviewed by Sam Weinig.

Inlined the fast path for creating an Identifier from an Identifier.

This is a .4% speedup on SunSpider overall, but as big as a 2.5%
speedup on certain individual tests. 65% of the Identifiers creating
by SunSpider are already Identifiers.

(The main reason I'm making this change is that it resolves a large
regression in a patch I haven't checked in yet.)

• JavaScriptCore.exp:
• kjs/identifier.cpp: (KJS::Identifier::addSlowCase):
• kjs/identifier.h: (KJS::Identifier::Identifier::add):

File:

• trunk/JavaScriptCore/kjs/identifier.h (modified) (1 diff)

trunk/JavaScriptCore/kjs/identifier.h

@@ -76 +76 @@
         static PassRefPtr<UString::Rep> add(const char*);
         static PassRefPtr<UString::Rep> add(const UChar*, int length);
-        static PassRefPtr<UString::Rep> add(UString::Rep*);
+        static PassRefPtr<UString::Rep> Identifier::add(UString::Rep* r)
+        {
+            if (r->isIdentifier)
+                return r;
+            return addSlowCase(r);
+        }
+        static PassRefPtr<UString::Rep> addSlowCase(UString::Rep *r);
     };