Changeset 270298 in webkit for trunk/Source/JavaScriptCore/runtime/JSString.cpp

Timestamp:

Dec 1, 2020, 7:50:43 AM (5 years ago)

Author:

Alexey Shvayka

Message:

Remove unused getPrimitiveNumber() methods
​https://bugs.webkit.org/show_bug.cgi?id=219370

Reviewed by Mark Lam.

These methods were originated in KJS, have weird signature / return value,
are currently unused, and were displaced by toNumber() / toPrimitive().

• runtime/JSBigInt.cpp:

(JSC::JSBigInt::getPrimitiveNumber const): Deleted.

• runtime/JSBigInt.h:
• runtime/JSCJSValue.h:
• runtime/JSCJSValueInlines.h:

(JSC::JSValue::getPrimitiveNumber): Deleted.

• runtime/JSCell.cpp:

(JSC::JSCell::getPrimitiveNumber const): Deleted.

• runtime/JSCell.h:
• runtime/JSObject.cpp:

(JSC::JSObject::getPrimitiveNumber const): Deleted.

• runtime/JSObject.h:
• runtime/JSString.cpp:

(JSC::JSString::getPrimitiveNumber const): Deleted.

• runtime/JSString.h:

(JSC::JSString::toBoolean const):

• runtime/Symbol.cpp:

(JSC::Symbol::getPrimitiveNumber const): Deleted.

• runtime/Symbol.h:

File:

• trunk/Source/JavaScriptCore/runtime/JSString.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/JSString.cpp

@@ -383 +383 @@
 }
 
-bool JSString::getPrimitiveNumber(JSGlobalObject* globalObject, double& number, JSValue& result) const
-{
-    VM& vm = globalObject->vm();
-    auto scope = DECLARE_THROW_SCOPE(vm);
-    StringView view = unsafeView(globalObject);
-    RETURN_IF_EXCEPTION(scope, false);
-    result = this;
-    number = jsToNumber(view);
-    return false;
-}
-
 double JSString::toNumber(JSGlobalObject* globalObject) const
 {