Changeset 27201 in webkit for trunk/JavaScriptCore/kjs/operations.cpp

Timestamp:

Oct 28, 2007, 7:52:04 PM (18 years ago)

Author:

[email protected]

Message:

2007-10-28 Mark Rowe <​[email protected]>

Reviewed by Maciej and Tim.

Replace uses of isNaN and isInf with isnan and isinf, and
remove isNaN and isInf.

• kjs/config.h: Remove unused HAVE_'s
• kjs/date_object.cpp: (KJS::DateInstance::getTime): (KJS::DateInstance::getUTCTime): (KJS::DateProtoFunc::callAsFunction): (KJS::DateObjectImp::construct): (KJS::DateObjectFuncImp::callAsFunction):
• kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction):
• kjs/math_object.cpp: (MathFuncImp::callAsFunction):
• kjs/nodes2string.cpp: (KJS::isParserRoundTripNumber):
• kjs/number_object.cpp: (NumberProtoFunc::callAsFunction):
• kjs/operations.cpp:
• kjs/operations.h:
• kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction):
• kjs/ustring.cpp: (KJS::UString::from):
• kjs/value.cpp: (KJS::JSValue::toInteger): (KJS::JSValue::toInt32SlowCase): (KJS::JSValue::toUInt32SlowCase):

2007-10-28 Mark Rowe <​[email protected]>

Reviewed by Maciej.

Replace uses of isNaN and isInf with isnan and isinf.

• bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::setLength):

File:

• trunk/JavaScriptCore/kjs/operations.cpp (modified) (2 diffs)

trunk/JavaScriptCore/kjs/operations.cpp

@@ -29 +29 @@
 #include <wtf/MathExtras.h>
 
-#if HAVE(FUNC_ISINF) && HAVE(IEEEFP_H)
-#include <ieeefp.h>
-#endif
-
 #if HAVE(FLOAT_H)
 #include <float.h>
@@ -38 +34 @@
 
 namespace KJS {
-    
-#if !PLATFORM(DARWIN)
-
-// FIXME: Should probably be inlined on non-Darwin platforms too, and controlled exclusively
-// by HAVE macros rather than PLATFORM.
-
-// FIXME: Merge with isnan in MathExtras.h and remove this one entirely.
-bool isNaN(double d)
-{
-#if HAVE(FUNC_ISNAN)
-    return isnan(d);
-#elif HAVE(FLOAT_H)
-    return _isnan(d) != 0;
-#else
-    return !(d == d);
-#endif
-}
-
-// FIXME: Merge with isinf in MathExtras.h and remove this one entirely.
-bool isInf(double d)
-{
-    // FIXME: should be HAVE(_FPCLASS)
-#if PLATFORM(WIN_OS)
-    int fpClass = _fpclass(d);
-    return _FPCLASS_PINF == fpClass || _FPCLASS_NINF == fpClass;
-#elif HAVE(FUNC_ISINF)
-    return isinf(d);
-#elif HAVE(FUNC_FINITE)
-    return finite(d) == 0 && d == d;
-#elif HAVE(FUNC__FINITE)
-    return _finite(d) == 0 && d == d;
-#else
-    return false;
-#endif
-}
-
-bool isPosInf(double d)
-{
-    // FIXME: should be HAVE(_FPCLASS)
-#if PLATFORM(WIN_OS)
-    return _FPCLASS_PINF == _fpclass(d);
-#elif HAVE(FUNC_ISINF)
-    return (isinf(d) == 1);
-#elif HAVE(FUNC_FINITE)
-    return !finite(d) && d == d; // ### can we distinguish between + and - ?
-#elif HAVE(FUNC__FINITE)
-    return !_finite(d) && d == d; // ###
-#else
-    return false;
-#endif
-}
-
-bool isNegInf(double d)
-{
-    // FIXME: should be HAVE(_FPCLASS)
-#if PLATFORM(WIN_OS)
-    return _FPCLASS_NINF == _fpclass(d);
-#elif HAVE(FUNC_ISINF)
-    return (isinf(d) == -1);
-#elif HAVE(FUNC_FINITE)
-    return finite(d) == 0 && d == d; // ###
-#elif HAVE(FUNC__FINITE)
-    return _finite(d) == 0 && d == d; // ###
-#else
-    return false;
-#endif
-}
-
-#endif
 
 // ECMA 11.9.3