Changeset 27206 in webkit for trunk/JavaScriptCore/kjs/identifier.h

Timestamp:

Oct 28, 2007, 9:11:37 PM (18 years ago)

Author:

darin

Message:

Reviewed by Maciej.

• fix a storage leak where we ref the UString every time we replace a ResolveNode with a LocalVarAccessNode

• kjs/identifier.h: (KJS::Identifier::Identifier): Added a constructor that takes PlacementNewAdopt.

• kjs/nodes.h: (KJS::ResolveNode::ResolveNode): Initialize the ident with PlacementNewAdopt instead of the old value of ident.

• kjs/ustring.h: (KJS::UString::UString): Added a constructor that takes PlacementNewAdopt.

File:

• trunk/JavaScriptCore/kjs/identifier.h (modified) (2 diffs)

trunk/JavaScriptCore/kjs/identifier.h

@@ -1 +1 @@
 /*
- *  This file is part of the KDE libraries
- *  Copyright (C) 2003 Apple Computer, Inc
+ *  Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.
  *
  *  This library is free software; you can redistribute it and/or
@@ -35 +34 @@
         explicit Identifier(UString::Rep* rep) : _ustring(add(rep)) { } 
         explicit Identifier(const UString& s) : _ustring(add(s.rep())) { }
+
+        // Special constructor for cases where we overwrite an object in place.
+        Identifier(PlacementNewAdoptType) : _ustring(PlacementNewAdopt) { }
         
         const UString& ustring() const { return _ustring; }