Changeset 27206 in webkit for trunk/JavaScriptCore/kjs/nodes.h

Timestamp:

Oct 28, 2007, 9:11:37 PM (18 years ago)

Author:

darin

Message:

Reviewed by Maciej.

• fix a storage leak where we ref the UString every time we replace a ResolveNode with a LocalVarAccessNode

• kjs/identifier.h: (KJS::Identifier::Identifier): Added a constructor that takes PlacementNewAdopt.

• kjs/nodes.h: (KJS::ResolveNode::ResolveNode): Initialize the ident with PlacementNewAdopt instead of the old value of ident.

• kjs/ustring.h: (KJS::UString::UString): Added a constructor that takes PlacementNewAdopt.

File:

• trunk/JavaScriptCore/kjs/nodes.h (modified) (4 diffs)

trunk/JavaScriptCore/kjs/nodes.h

@@ -90 +90 @@
     };
   
-    // Specifies that a Node should adopt the memory layout it was initialized into.
-    // We use this to swap a pre-existing base class node with a more optimized 
-    // subclass node.
-    enum PlacementNewAdoptTag { PlacementNewAdopt };
-
   struct DeclarationStacks {
       typedef Vector<Node*, 16> NodeStack;
@@ -117 +112 @@
   public:
     Node() KJS_FAST_CALL;
-    Node(PlacementNewAdoptTag) KJS_FAST_CALL { }
+    Node(PlacementNewAdoptType) KJS_FAST_CALL { }
     virtual ~Node();
 
@@ -274 +269 @@
     }
 
-    ResolveNode(PlacementNewAdoptTag) KJS_FAST_CALL 
+    // Special constructor for cases where we overwrite an object in place.
+    ResolveNode(PlacementNewAdoptType) KJS_FAST_CALL 
         : Node(PlacementNewAdopt)
-        , ident(ident) 
+        , ident(PlacementNewAdopt) 
     {
     }
@@ -297 +293 @@
   class LocalVarAccessNode : public ResolveNode {
   public:
+    // Overwrites a ResolveNode in place.
     LocalVarAccessNode(size_t i)
         : ResolveNode(PlacementNewAdopt)