Changeset 27207 in webkit for trunk/JavaScriptCore/API/testapi.c

Timestamp:

Oct 28, 2007, 9:31:54 PM (18 years ago)

Author:

darin

Message:

Reviewed by Adam.

• turn on unused parameter waring on Mac OS X because it's already on elsewhere

• Configurations/Base.xcconfig: Took out -wno-unused-parameter.

• API/JSNode.c:
• API/JSNodeList.c:
• API/minidom.c:
• API/testapi.c: Fixed unused variables by using them or marked them with UNUSED_PARAM.

• kjs/CollectorHeapIntrospector.h: (KJS::CollectorHeapIntrospector::zoneCalloc): Removed parameter names to indicate they are unused.

File:

• trunk/JavaScriptCore/API/testapi.c (modified) (16 diffs)

trunk/JavaScriptCore/API/testapi.c

@@ -142 +142 @@
     UNUSED_PARAM(object);
     UNUSED_PARAM(value);
+    UNUSED_PARAM(exception);
 
     if (JSStringIsEqualToUTF8CString(propertyName, "cantSet"))
@@ -168 +169 @@
 {
     UNUSED_PARAM(context);
+    UNUSED_PARAM(object);
     
     JSStringRef propertyName;
@@ -185 +187 @@
     UNUSED_PARAM(object);
     UNUSED_PARAM(thisObject);
+    UNUSED_PARAM(exception);
 
     if (argumentCount > 0 && JSValueIsStrictEqual(context, arguments[0], JSValueMakeNumber(context, 0)))
@@ -198 +201 @@
 
     if (argumentCount > 0 && JSValueIsStrictEqual(context, arguments[0], JSValueMakeNumber(context, 0)))
-        return JSValueToObject(context, JSValueMakeNumber(context, 1), NULL);
-    
-    return JSValueToObject(context, JSValueMakeNumber(context, 0), NULL);
+        return JSValueToObject(context, JSValueMakeNumber(context, 1), exception);
+    
+    return JSValueToObject(context, JSValueMakeNumber(context, 0), exception);
 }
 
@@ -206 +209 @@
 {
     UNUSED_PARAM(context);
+    UNUSED_PARAM(constructor);
 
     JSStringRef numberString = JSStringCreateWithUTF8CString("Number");
-    JSObjectRef numberConstructor = JSValueToObject(context, JSObjectGetProperty(context, JSContextGetGlobalObject(context), numberString, NULL), NULL);
+    JSObjectRef numberConstructor = JSValueToObject(context, JSObjectGetProperty(context, JSContextGetGlobalObject(context), numberString, exception), exception);
     JSStringRelease(numberString);
 
-    return JSValueIsInstanceOfConstructor(context, possibleValue, numberConstructor, NULL);
+    return JSValueIsInstanceOfConstructor(context, possibleValue, numberConstructor, exception);
 }
 
 static JSValueRef MyObject_convertToType(JSContextRef context, JSObjectRef object, JSType type, JSValueRef* exception)
 {
-    UNUSED_PARAM(context);
-    UNUSED_PARAM(object);
+    UNUSED_PARAM(object);
+    UNUSED_PARAM(exception);
     
     switch (type) {
@@ -265 +269 @@
 static JSClassRef MyObject_class(JSContextRef context)
 {
+    UNUSED_PARAM(context);
+
     static JSClassRef jsClass;
     if (!jsClass)
@@ -274 +280 @@
 static JSValueRef Base_get(JSContextRef ctx, JSObjectRef object, JSStringRef propertyName, JSValueRef* exception)
 {
-    UNUSED_PARAM(ctx);
     UNUSED_PARAM(object);
     UNUSED_PARAM(propertyName);
+    UNUSED_PARAM(exception);
 
     return JSValueMakeNumber(ctx, 1); // distinguish base get form derived get
@@ -283 +289 @@
 static bool Base_set(JSContextRef ctx, JSObjectRef object, JSStringRef propertyName, JSValueRef value, JSValueRef* exception)
 {
-    UNUSED_PARAM(ctx);
     UNUSED_PARAM(object);
     UNUSED_PARAM(propertyName);
@@ -294 +299 @@
 static JSValueRef Base_callAsFunction(JSContextRef ctx, JSObjectRef function, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception)
 {
-    UNUSED_PARAM(ctx);
     UNUSED_PARAM(function);
     UNUSED_PARAM(thisObject);
     UNUSED_PARAM(argumentCount);
     UNUSED_PARAM(arguments);
+    UNUSED_PARAM(exception);
     
     return JSValueMakeNumber(ctx, 1); // distinguish base call from derived call
@@ -318 +323 @@
 static void Base_initialize(JSContextRef context, JSObjectRef object)
 {
+    UNUSED_PARAM(context);
+
     if (TestInitializeFinalize) {
         ASSERT((void*)1 == JSObjectGetPrivate(object));
@@ -335 +342 @@
 static JSClassRef Base_class(JSContextRef context)
 {
+    UNUSED_PARAM(context);
+
     static JSClassRef jsClass;
     if (!jsClass) {
@@ -349 +358 @@
 static JSValueRef Derived_get(JSContextRef ctx, JSObjectRef object, JSStringRef propertyName, JSValueRef* exception)
 {
-    UNUSED_PARAM(ctx);
     UNUSED_PARAM(object);
     UNUSED_PARAM(propertyName);
+    UNUSED_PARAM(exception);
 
     return JSValueMakeNumber(ctx, 2); // distinguish base get form derived get
@@ -369 +378 @@
 static JSValueRef Derived_callAsFunction(JSContextRef ctx, JSObjectRef function, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception)
 {
-    UNUSED_PARAM(ctx);
     UNUSED_PARAM(function);
     UNUSED_PARAM(thisObject);
     UNUSED_PARAM(argumentCount);
     UNUSED_PARAM(arguments);
+    UNUSED_PARAM(exception);
     
     return JSValueMakeNumber(ctx, 2); // distinguish base call from derived call
@@ -394 +403 @@
 static void Derived_initialize(JSContextRef context, JSObjectRef object)
 {
+    UNUSED_PARAM(context);
+
     if (TestInitializeFinalize) {
         ASSERT((void*)2 == JSObjectGetPrivate(object));
@@ -427 +438 @@
     UNUSED_PARAM(functionObject);
     UNUSED_PARAM(thisObject);
+    UNUSED_PARAM(exception);
     
     if (argumentCount > 0) {
@@ -443 +455 @@
 {
     UNUSED_PARAM(constructorObject);
+    UNUSED_PARAM(exception);
     
     JSObjectRef result = JSObjectMake(context, NULL, NULL);