Changeset 27218 in webkit for trunk/JavaScriptCore/kjs/string_object.h

Timestamp:

Oct 29, 2007, 12:55:34 AM (18 years ago)

Author:

eseidel

Message:

2007-10-29 Eric Seidel <​[email protected]>

Reviewed by darin.

Give StringInstance a getOwnPropertySlot(ExecState, unsigned, PropertySlot) fastpath, just like Arrays.
Make it a compile time error to use toString(ExecState) on a StringInstance

SunSpider claims this was a 6.6% speedup overall (22% on string-base64)

• kjs/internal.h: (KJS::StringImp::getLength):
• kjs/string_object.cpp: (KJS::StringInstance::lengthGetter): (KJS::StringInstance::inlineGetOwnPropertySlot): (KJS::StringInstance::getOwnPropertySlot):
• kjs/string_object.h:

File:

• trunk/JavaScriptCore/kjs/string_object.h (modified) (2 diffs)

trunk/JavaScriptCore/kjs/string_object.h

@@ -32 +32 @@
   public:
     StringInstance(JSObject *proto);
-    StringInstance(JSObject *proto, StringImp* string);
-    StringInstance(JSObject *proto, const UString &string);
+    StringInstance(JSObject *proto, StringImp*);
+    StringInstance(JSObject *proto, const UString&);
 
     virtual bool getOwnPropertySlot(ExecState*, const Identifier&, PropertySlot&);
-    virtual void put(ExecState* exec, const Identifier& propertyName, JSValue* value, int attr = None);
+    virtual bool getOwnPropertySlot(ExecState*, unsigned propertyName, PropertySlot&);
+
+    virtual void put(ExecState* exec, const Identifier& propertyName, JSValue*, int attr = None);
     virtual bool deleteProperty(ExecState* exec, const Identifier& propertyName);
     virtual void getPropertyNames(ExecState*, PropertyNameArray&);
@@ -46 +48 @@
 
   private:
-    static JSValue *lengthGetter(ExecState *exec, JSObject *, const Identifier&, const PropertySlot &slot);
-    static JSValue *indexGetter(ExecState *exec, JSObject *, const Identifier&, const PropertySlot &slot);
+    bool inlineGetOwnPropertySlot(ExecState*, unsigned, PropertySlot&);
+
+    static JSValue* lengthGetter(ExecState*, JSObject *, const Identifier&, const PropertySlot&);
+    static JSValue* indexGetter(ExecState*, JSObject *, const Identifier&, const PropertySlot&);
   };