Changeset 27222 in webkit for trunk/JavaScriptCore/kjs/string_object.cpp

Timestamp:

Oct 29, 2007, 2:14:08 AM (18 years ago)

Author:

eseidel

Message:

2007-10-29 Eric Seidel <​[email protected]>

Reviewed by Maciej.

SunSpider claims this was a 0.7% speedup.

• kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction): avoid mallocing a jsString in the common case

File:

• trunk/JavaScriptCore/kjs/string_object.cpp (modified) (2 diffs)

trunk/JavaScriptCore/kjs/string_object.cpp

@@ -444 +444 @@
   // toString and valueOf are no generic function.
   if (id == ToString || id == ValueOf) {
-    if (!thisObj || !thisObj->inherits(&StringInstance::info))
+    if (!thisObj->inherits(&StringInstance::info))
       return throwError(exec, TypeError);
 
@@ -455 +455 @@
   double d = 0.0;
 
-  UString s = thisObj->toString(exec);
+  // This optimizes the common case that thisObj is a StringInstance
+  UString s = thisObj->inherits(&StringInstance::info) ? static_cast<StringInstance*>(thisObj)->internalValue()->value() : thisObj->toString(exec);
 
   int len = s.size();