Changeset 27255 in webkit for trunk/JavaScriptCore/kjs/nodes.h

Timestamp:

Oct 29, 2007, 10:36:24 PM (18 years ago)

Author:

oliver

Message:

Debranching remaining assignment nodes, and miscellaneous cleanup

Reviewed by Maciej.

Split read-modify code paths out of AssignBracketNode and AssignDotNode
Removed now unnecessary check for write-only assignment in ReadModifyLocalVarNode
and ReadModifyResolveNode evaluate methods

Leads to a 1% gain in SunSpider.

File:

• trunk/JavaScriptCore/kjs/nodes.h (modified) (2 diffs)

trunk/JavaScriptCore/kjs/nodes.h

@@ -1366 +1366 @@
   };
 
-  class AssignBracketNode : public Node {
-  public:
-    AssignBracketNode(Node *base, Node *subscript, Operator oper, Node *right) KJS_FAST_CALL
+  class ReadModifyBracketNode : public Node {
+  public:
+    ReadModifyBracketNode(Node *base, Node *subscript, Operator oper, Node *right) KJS_FAST_CALL
       : m_base(base), m_subscript(subscript), m_oper(oper), m_right(right) {}
     virtual void optimizeVariableAccess(FunctionBodyNode*, DeclarationStacks::NodeStack&) KJS_FAST_CALL;
@@ -1381 +1381 @@
   };
 
+  class AssignBracketNode : public Node {
+  public:
+    AssignBracketNode(Node *base, Node *subscript, Node *right) KJS_FAST_CALL
+      : m_base(base), m_subscript(subscript), m_right(right) {}
+    virtual void optimizeVariableAccess(FunctionBodyNode*, DeclarationStacks::NodeStack&) KJS_FAST_CALL;
+    JSValue* evaluate(ExecState*) KJS_FAST_CALL;
+    virtual void streamTo(SourceStream&) const KJS_FAST_CALL;
+    virtual Precedence precedence() const { return PrecAssignment; }
+  protected:
+    RefPtr<Node> m_base;
+    RefPtr<Node> m_subscript;
+    RefPtr<Node> m_right;
+  };
+
   class AssignDotNode : public Node {
   public:
-    AssignDotNode(Node *base, const Identifier& ident, Operator oper, Node *right) KJS_FAST_CALL
+    AssignDotNode(Node *base, const Identifier& ident, Node *right) KJS_FAST_CALL
+      : m_base(base), m_ident(ident), m_right(right) {}
+    virtual void optimizeVariableAccess(FunctionBodyNode*, DeclarationStacks::NodeStack&) KJS_FAST_CALL;
+    JSValue* evaluate(ExecState*) KJS_FAST_CALL;
+    virtual void streamTo(SourceStream&) const KJS_FAST_CALL;
+    virtual Precedence precedence() const { return PrecAssignment; }
+  protected:
+    RefPtr<Node> m_base;
+    Identifier m_ident;
+    RefPtr<Node> m_right;
+  };
+
+  class ReadModifyDotNode : public Node {
+  public:
+    ReadModifyDotNode(Node *base, const Identifier& ident, Operator oper, Node *right) KJS_FAST_CALL
       : m_base(base), m_ident(ident), m_oper(oper), m_right(right) {}
     virtual void optimizeVariableAccess(FunctionBodyNode*, DeclarationStacks::NodeStack&) KJS_FAST_CALL;