Changeset 27344 in webkit for trunk/JavaScriptCore/kjs/ExecState.cpp

Timestamp:

Nov 1, 2007, 1:36:58 AM (18 years ago)

Author:

ggaren

Message:

Reviewed by Oliver Hunt.

Removed List from ActivationImp, in preparation for making all lists
stack-allocated.

Tests pass.

1.0% speedup on SunSpider, presumably due to reduced List refcount thrash.

• kjs/ExecState.cpp: (KJS::ExecState::ExecState): (KJS::ExecState::~ExecState):
• kjs/function.cpp: (KJS::ActivationImp::ActivationImp): (KJS::ActivationImp::createArgumentsObject):
• kjs/function.h: (KJS::ActivationImp::ActivationImpPrivate::ActivationImpPrivate):

File:

• trunk/JavaScriptCore/kjs/ExecState.cpp (modified) (2 diffs)

trunk/JavaScriptCore/kjs/ExecState.cpp

@@ -52 +52 @@
     // create and initialize activation object (ECMA 10.1.6)
     if (type == FunctionCode) {
-        m_activation = new ActivationImp(func, *args);
+        m_activation = new ActivationImp(this);
         m_variable = m_activation;
     } else {
@@ -88 +88 @@
 {
     m_interpreter->setCurrentExec(m_savedExecState);
-
-    // The arguments list is only needed to potentially create the  arguments object, 
-    // which isn't accessible from nested scopes so we can discard the list as soon 
-    // as the function is done running.
-    // This prevents lists of Lists from building up, waiting to be garbage collected
-    ActivationImp* activation = static_cast<ActivationImp*>(m_activation);
-    if (activation)
-        activation->releaseArguments();
 }