Changeset 27344 in webkit for trunk/JavaScriptCore/kjs/function.cpp

Timestamp:

Nov 1, 2007, 1:36:58 AM (18 years ago)

Author:

ggaren

Message:

Reviewed by Oliver Hunt.

Removed List from ActivationImp, in preparation for making all lists
stack-allocated.

Tests pass.

1.0% speedup on SunSpider, presumably due to reduced List refcount thrash.

• kjs/ExecState.cpp: (KJS::ExecState::ExecState): (KJS::ExecState::~ExecState):
• kjs/function.cpp: (KJS::ActivationImp::ActivationImp): (KJS::ActivationImp::createArgumentsObject):
• kjs/function.h: (KJS::ActivationImp::ActivationImpPrivate::ActivationImpPrivate):

File:

• trunk/JavaScriptCore/kjs/function.cpp (modified) (3 diffs)

trunk/JavaScriptCore/kjs/function.cpp

@@ -393 +393 @@
 const ClassInfo ActivationImp::info = {"Activation", 0, 0, 0};
 
-ActivationImp::ActivationImp(FunctionImp* function, const List& arguments)
-    : d(new ActivationImpPrivate(function, arguments))
-    , m_symbolTable(&function->body->symbolTable())
+ActivationImp::ActivationImp(ExecState* exec)
+    : d(new ActivationImpPrivate(exec))
+    , m_symbolTable(&exec->function()->body->symbolTable())
 {
 }
@@ -479 +479 @@
     JSObject::mark();
 
-    if (!d->function->marked())
-        d->function->mark();
-
     size_t size = d->localStorage.size();
     for (size_t i = 0; i < size; ++i) {
@@ -495 +492 @@
 void ActivationImp::createArgumentsObject(ExecState* exec)
 {
-  d->argumentsObject = new Arguments(exec, d->function, d->arguments, this);
-
-  // The arguments list is only needed to create the arguments object, so discard it now.
-  // This prevents lists of Lists from building up, waiting to be garbage collected.
-  d->arguments.reset();
+    d->argumentsObject = new Arguments(exec, d->exec->function(), *d->exec->arguments(), this);
 }