Changeset 27344 in webkit for trunk/JavaScriptCore/kjs/function.h

Timestamp:

Nov 1, 2007, 1:36:58 AM (18 years ago)

Author:

ggaren

Message:

Reviewed by Oliver Hunt.

Removed List from ActivationImp, in preparation for making all lists
stack-allocated.

Tests pass.

1.0% speedup on SunSpider, presumably due to reduced List refcount thrash.

• kjs/ExecState.cpp: (KJS::ExecState::ExecState): (KJS::ExecState::~ExecState):
• kjs/function.cpp: (KJS::ActivationImp::ActivationImp): (KJS::ActivationImp::createArgumentsObject):
• kjs/function.h: (KJS::ActivationImp::ActivationImpPrivate::ActivationImpPrivate):

File:

• trunk/JavaScriptCore/kjs/function.h (modified) (2 diffs)

trunk/JavaScriptCore/kjs/function.h

@@ -141 +141 @@
   private:
     struct ActivationImpPrivate {
-        ActivationImpPrivate(FunctionImp* f, const List& a)
-            : function(f)
-            , arguments(a)
+        ActivationImpPrivate(ExecState* e)
+            : exec(e)
             , argumentsObject(0)
         {
-            ASSERT(f);
         }
         
-        FunctionImp* function;
         LocalStorage localStorage;
-
-        List arguments;
+        ExecState* exec;
         Arguments* argumentsObject;
     };
 
   public:
-    ActivationImp(FunctionImp* function, const List& arguments);
+    ActivationImp(ExecState*);
 
     virtual bool getOwnPropertySlot(ExecState*, const Identifier&, PropertySlot&);
@@ -170 +166 @@
     bool isActivation() { return true; }
 
-    void releaseArguments() { d->arguments.reset(); }
-    
     LocalStorage& localStorage() { return d->localStorage; }
     SymbolTable& symbolTable() { return *m_symbolTable; }