Changeset 2736 in webkit for trunk/JavaScriptCore/kjs/function.cpp

Timestamp:

Nov 18, 2002, 1:55:23 PM (23 years ago)

Author:

darin

Message:

• fix worst speed problems on the sort page of the iBench JavaScript test

Sped up JavaScript iBench by 70%, the sort page by 88%.

• kjs/array_object.h: Add array-specific sort functions.
• kjs/array_object.cpp: (compareByStringForQSort): Added. (ArrayInstanceImp::sort): Added. (compareWithCompareFunctionForQSort): Added. (ArrayProtoFuncImp::call): Use ArrayInstanceImp::sort if the object being sorted is actually an array.

• kjs/object.h: Add argumentsPropertyName.
• kjs/object.cpp: Add argumentsPropertyName.
• kjs/function.cpp: (FunctionImp::FunctionImp): Use argumentsPropertyName to avoid making a UString. (FunctionImp::call): Ditto. (ActivationImp::ActivationImp): Ditto.
• kjs/function_object.cpp: (FunctionObjectImp::construct): Ditto.

• kjs/ustring.h: Added compare function for -1/0/+1 comparison.
• kjs/ustring.cpp: (KJS::compare): Added.

File:

• trunk/JavaScriptCore/kjs/function.cpp (modified) (4 diffs)

trunk/JavaScriptCore/kjs/function.cpp

@@ -60 +60 @@
   Value protect(this);
   //fprintf(stderr,"FunctionImp::FunctionImp this=%p\n");
-  put(exec,"arguments",Null(),ReadOnly|DontDelete|DontEnum);
+  put(exec,argumentsPropertyName,Null(),ReadOnly|DontDelete|DontEnum);
 }
 
@@ -109 +109 @@
   // previous arguments object.
   // Note: this does not appear to be part of the spec
-  Value oldArgs = get(&newExec, "arguments");
+  Value oldArgs = get(&newExec, argumentsPropertyName);
 
   if (codeType() == FunctionCode) {
     assert(ctx.activationObject().inherits(&ActivationImp::info));
     Object argsObj = static_cast<ActivationImp*>(ctx.activationObject().imp())->argumentsObject();
-    put(&newExec, "arguments", argsObj, DontDelete|DontEnum|ReadOnly);
+    put(&newExec, argumentsPropertyName, argsObj, DontDelete|DontEnum|ReadOnly);
   }
 
@@ -128 +128 @@
     exec->setException(newExec.exception());
   if (codeType() == FunctionCode)
-    put(&newExec, "arguments", oldArgs, DontDelete|DontEnum|ReadOnly);
+    put(&newExec, argumentsPropertyName, oldArgs, DontDelete|DontEnum|ReadOnly);
 
 #ifdef KJS_VERBOSE
@@ -309 +309 @@
   Value protect(this);
   arguments = new ArgumentsImp(exec,f, args);
-  put(exec, "arguments", Object(arguments), Internal|DontDelete);
+  put(exec, argumentsPropertyName, Object(arguments), Internal|DontDelete);
 }