Changeset 2736 in webkit for trunk/JavaScriptCore/kjs/ustring.cpp

Timestamp:

Nov 18, 2002, 1:55:23 PM (23 years ago)

Author:

darin

Message:

• fix worst speed problems on the sort page of the iBench JavaScript test

Sped up JavaScript iBench by 70%, the sort page by 88%.

• kjs/array_object.h: Add array-specific sort functions.
• kjs/array_object.cpp: (compareByStringForQSort): Added. (ArrayInstanceImp::sort): Added. (compareWithCompareFunctionForQSort): Added. (ArrayProtoFuncImp::call): Use ArrayInstanceImp::sort if the object being sorted is actually an array.

• kjs/object.h: Add argumentsPropertyName.
• kjs/object.cpp: Add argumentsPropertyName.
• kjs/function.cpp: (FunctionImp::FunctionImp): Use argumentsPropertyName to avoid making a UString. (FunctionImp::call): Ditto. (ActivationImp::ActivationImp): Ditto.
• kjs/function_object.cpp: (FunctionObjectImp::construct): Ditto.

• kjs/ustring.h: Added compare function for -1/0/+1 comparison.
• kjs/ustring.cpp: (KJS::compare): Added.

File:

• trunk/JavaScriptCore/kjs/ustring.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/ustring.cpp

@@ -643 +643 @@
   return (l1 < l2);
 }
+
+int KJS::compare(const UString& s1, const UString& s2)
+{
+  const int l1 = s1.size();
+  const int l2 = s2.size();
+  const int lmin = l1 < l2 ? l1 : l2;
+  const UChar *c1 = s1.data();
+  const UChar *c2 = s2.data();
+  int l = 0;
+  while (l < lmin && *c1 == *c2) {
+    c1++;
+    c2++;
+    l++;
+  }
+  if (l < lmin)
+    return (c1->unicode() > c2->unicode()) ? 1 : -1;
+
+  if (l1 == l2) {
+    return 0;
+  }
+  return (l1 < l2) ? 1 : -1;
+}