Changeset 2738 in webkit for trunk/JavaScriptCore/kjs/interpreter.h

Timestamp:

Nov 18, 2002, 2:49:26 PM (23 years ago)

Author:

darin

Message:

• simplified the ExecState class, which was showing up in profiles

Sped up JavaScript iBench by 6%.

• kjs/interpreter.h: Removed the level of indirection, and made it all inline.
• kjs/interpreter.cpp: Removed ExecState implementation from here altogether.

• fixed an oversight in my sort speedup

• kjs/array_object.h: Add pushUndefinedObjectsToEnd.
• kjs/array_object.cpp: (ArrayInstanceImp::sort): Call pushUndefinedObjectsToEnd. (ArrayInstanceImp::pushUndefinedObjectsToEnd): Added. Pushes all undefined to the end of the array.

File:

• trunk/JavaScriptCore/kjs/interpreter.h (modified) (3 diffs)

trunk/JavaScriptCore/kjs/interpreter.h

@@ -369 +369 @@
     friend class GlobalFuncImp;
   public:
-    virtual ~ExecState();
-
     /**
      * Returns the interpreter associated with this execution state
@@ -376 +374 @@
      * @return The interpreter executing the script
      */
-    Interpreter *interpreter() const;
+    Interpreter *interpreter() const { return _interpreter; }
 
     /**
@@ -383 +381 @@
      * @return The current execution state context
      */
-    const Context context() const;
-
-    void setException(const Value &e);
-    void clearException();
-    Value exception() const;
-    bool hadException() const;
+    const Context context() const { return _context; }
+
+    void setException(const Value &e) { _exception = e; }
+    void clearException() { _exception = Value(); }
+    Value exception() const { return _exception; }
+    bool hadException() const { return !_exception.isNull(); }
 
   private:
-    ExecState(Interpreter *interp, ContextImp *con);
-    ExecStateImp *rep;
+    ExecState(Interpreter *interp, ContextImp *con)
+        : _interpreter(interp), _context(con) { }
+    Interpreter *_interpreter;
+    ContextImp *_context;
+    Value _exception;
   };